You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "mariofusco (via GitHub)" <gi...@apache.org> on 2024/02/15 16:47:54 UTC
[PR] [DROOLS-7608] fix KieProject lookup on classpath for EAP 7.4.15 VFS [incubator-kie-drools]
mariofusco opened a new pull request, #5691:
URL: https://github.com/apache/incubator-kie-drools/pull/5691
@tkobayas This is only a rewritten and cleaned up version of the solution that you found [here](https://github.com/kiegroup/drools/pull/25).
I dug into VFS sources a lot and couldn't find any better solution. I understand that using reflection is not ideal, but in the end we were already doing so, even if just because we didn't want a direct dependency on VFS. Now it's true that this is a bit worse than before because we're also accessing package private methods (that are probably subject to change in future), but other than asking the Jboss team to make those methods public, thus avoiding to use `setAccessible(true)`, I don't see any possible improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [DROOLS-7608] fix KieProject lookup on classpath for EAP 7.4.15 VFS [incubator-kie-drools]
Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco closed pull request #5691: [DROOLS-7608] fix KieProject lookup on classpath for EAP 7.4.15 VFS
URL: https://github.com/apache/incubator-kie-drools/pull/5691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [DROOLS-7608] fix KieProject lookup on classpath for EAP 7.4.15 VFS [incubator-kie-drools]
Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco commented on PR #5691:
URL: https://github.com/apache/incubator-kie-drools/pull/5691#issuecomment-1946596754
Replaced by https://github.com/kiegroup/drools/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org