You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "DavidLiu (Jira)" <ji...@apache.org> on 2022/07/22 06:38:00 UTC
[jira] [Comment Edited] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

    [ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569835#comment-17569835 ] 

DavidLiu edited comment on FLINK-27537 at 7/22/22 6:37 AM:
-----------------------------------------------------------

The following files will be covered.

[flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java|https://github.com/apache/flink/blob/423143c1a9dcfba2c8ddc08f4c785451b82802be/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java]

 

[flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/table/sink/AsyncDynamicTableSink.java|https://github.com/apache/flink/blob/bdfabeba60db1096ed7e100ed12c4837da5935d7/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/table/sink/AsyncDynamicTableSink.java]

 

[flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java|https://github.com/apache/flink/blob/25ecc0b9202050b340fb4d6fc95b0585a8119937/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java]

 

[flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java|https://github.com/apache/flink/blob/a2df2665b6ff411a2aeb9b204fd9d46a2af0ecfa/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java]


was (Author: JIRAUSER289843):
[flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java|https://github.com/apache/flink/blob/423143c1a9dcfba2c8ddc08f4c785451b82802be/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java]

> Remove requirement for Async Sink's RequestEntryT to be serializable
> --------------------------------------------------------------------
>
>                 Key: FLINK-27537
>                 URL: https://issues.apache.org/jira/browse/FLINK-27537
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Common
>    Affects Versions: 1.15.0
>            Reporter: Zichen Liu
>            Assignee: DavidLiu
>            Priority: Major
>
> Currently, in AsyncSinkBase and it's dependent classes, e.g. the sink writer, element converter etc., the RequestEntryT generic type is required to be serializable.
> However, this requirement no longer holds and there is nothing that actually requires this.
> Proposed approach:
>  * Remove the extends serializable from the generic type RequestEntryT



--
This message was sent by Atlassian Jira
(v8.20.10#820010)