[jira] [Commented] (HBASE-9243) Add more useful statistics in the HFile tool

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741991#comment-13741991 ] 

Hadoop QA commented on HBASE-9243:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12598361/HBASE-9243.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6778//console

This message is automatically generated.
                
> Add more useful statistics in the HFile tool
> --------------------------------------------
>
>                 Key: HBASE-9243
>                 URL: https://issues.apache.org/jira/browse/HBASE-9243
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>    Affects Versions: 0.96.0
>            Reporter: Alexandre Normand
>            Priority: Minor
>              Labels: newbie
>         Attachments: HBASE-9243.patch
>
>
> The [HFile tool|http://hbase.apache.org/book/regions.arch.html#hfile_tool] has been very useful to us recently to get a better idea of the size of our rows. However, it happened frequently that we wished for more statistics to have a more complete picture of the distribution of the row sizes. 
> [~skuehn] requested that feature often enough in private that I decided to give it a go. 
> Here's the patch that adds more nice little stats via yammer's histograms. It was easy enough since {{com.yammer.metrics}} is already in hbase's dependencies.
> Example of the new output from {{org.apache.hadoop.hbase.io.hfile.HFile -s -f ...}}:
> {code}
> Stats:
> 	Key length:
>                min = 24.00
>                max = 24.00
>               mean = 24.00
>             stddev = 0.00
>             median = 24.00
>               75% <= 24.00
>               95% <= 24.00
>               98% <= 24.00
>               99% <= 24.00
>             99.9% <= 24.00
> 	Row size (bytes):
>                min = 33.00
>                max = 33.00
>               mean = 33.00
>             stddev = 0.00
>             median = 33.00
>               75% <= 33.00
>               95% <= 33.00
>               98% <= 33.00
>               99% <= 33.00
>             99.9% <= 33.00
> 	Row size (columns):
>                min = 1.00
>                max = 1.00
>               mean = 1.00
>             stddev = 0.00
>             median = 1.00
>               75% <= 1.00
>               95% <= 1.00
>               98% <= 1.00
>               99% <= 1.00
>             99.9% <= 1.00
> 	Val length:
>                min = 1.00
>                max = 1.00
>               mean = 1.00
>             stddev = 0.00
>             median = 1.00
>               75% <= 1.00
>               95% <= 1.00
>               98% <= 1.00
>               99% <= 1.00
>             99.9% <= 1.00
> Key of biggest row: \x00
> {code}  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira