You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 14:02:14 UTC

[GitHub] [flink] godfreyhe commented on a change in pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify

godfreyhe commented on a change in pull request #13793:
URL: https://github.com/apache/flink/pull/13793#discussion_r511982465



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -196,14 +196,23 @@ object FlinkRexUtil {
     * 4. (a > b OR c < 10) OR b < a -> a > b OR c < 10
     * 5. a = a, a >= a, a <= a -> true
     * 6. a <> a, a > a, a < a -> false
+    * 7. a = 2020 AND SEARCH(a, [2020, 2021]) -> a = 2020

Review comment:
       does `a = 2020 OR SEARCH(a, [2020, 2021])` can be simplified as `a = 2020`  ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org