You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org> on 2006/10/10 18:23:19 UTC
[jira] Created: (ADFFACES-234) Filter logic for Portlets
Filter logic for Portlets
-------------------------
Key: ADFFACES-234
URL: http://issues.apache.org/jira/browse/ADFFACES-234
Project: MyFaces ADF-Faces
Issue Type: Improvement
Components: Portlet
Environment: JSR-168
Reporter: Scott O'Bryan
The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-234:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: https://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Affects Versions: 1.0.0-incubating-core
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Fix For: 1.0.0-incubating-core
>
> Attachments: 1-ADFFACES-234.patch, 11-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch, 9-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Attachment: 8-ADFFACES-234.patch
This is an update of the previous 8-ADFFACES-242.patch. The old one had some duplicated files. In addition this patch also gets rid of the GlobalConfigurator in API and the global configurator can no longer be obtained from the api.
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Attachment: (was: 8-ADFFACES-234.patch)
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 7-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Attachment: 1-ADFFACES-234.patch
This patch introduces the following enhancements.
1. Configurators - these are services that supply initialization and destruction based on the webapplication, beforeRequest and endRequest processing as well as externalContext wrapping in both portal and servlet environments.
2. TrinidadFacesContext - an implementaion of FacesContext and ExternalContext which can be used to support ExternalContextWrapping and the Trinidad ResourceServlets
3. TrinidadListener - a context listener which is needed for cleanup of the Configurator Objects
4. Portlet Request, Response, and Context wrappers which can be used to create ExternalContext wrappers for Portal Environments
There are also numerous enhancements within Trinidad to support these new API's. This patch has the following limitations which should be ironed out at some point before it will run in a portal.
1. LaunchParameters which are used for dialogs are not yet implemented and will hopefully be supplied in a later patch
This patch will require webapps to add a <listener> to their web.xml in addition to the filter. This listener should be added to both Portlet and Portal environments.
*Note* - Due to the impact of these changes, this patch should be added to the Portal Branch so it can be tested before being moved into the Trunk.
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Adam Winer updated ADFFACES-234:
--------------------------------
Status: Open (was: Patch Available)
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Attachment: 11-ADFFACES-234.patch
This is a patch for the jwaldman-portal branch to fix a few issues.
1. The web.xml file was erroneously modified to include the MyFaces context listener
2. The API for UploadFileProcessor was changed back to it's original form in order to maintain Backward Compatibility
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: https://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 11-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch, 9-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Status: Patch Available (was: Open)
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Attachment: 7-ADFFACES-234.patch
8-ADFFACES-234.patch
Updates to the Portal enhancements based on Adams comments. These patches assume you've already applied the first patch in this set as well as the patches from the following JIRA issues:
ADFFACES-232
ADFFACES-231
ADFFACES-235
Apply 7-ADFFACES-234.patch before 8-ADFFACES-234.patch.
The following changes are included in 8-ADFFACES-234.patch:
* Remove GenericConfigurator and change Configurator into an abstract class
* Change resource servlets back to using the FactoryFinder
* Add a disableConfiguratorServicesForRequest attribute to disable configurator services when the FacesContext is obtained
* Moved all ExternalContext helpers to impl and removed the ones that were no longer needed
* Moved all WebApp wrappers to impl
* Removed public context listener and added initialization of the context to tr.tld
And fixed many other issues associated with these changes. There remains one more open issue and that is whether or not to remove the GlobalConfigurator API altogether. If it is decided that this needs to be done then this will be part of another patch.
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan resolved ADFFACES-234.
------------------------------------
Resolution: Fixed
Fixed ADFFACES-329
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: https://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 11-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch, 9-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-234) Filter logic for Portlets
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=all ]
Scott O'Bryan updated ADFFACES-234:
-----------------------------------
Attachment: 9-ADFFACES-234.patch
This is a patch to some code contributed by Adam to the portal branch.
1. It makes the API's within the GlobalConfiguratorImpl class a bit more robust
2. Adds initialization to the beginRequest rather then to the getInstance, removing the dependency on the ExternalContext
3. getInstance was removed from the public "configurator" interface and moved to the the GlobalConfiguratorImpl object in the impl package
4. Error checking is now handled by the GlobalConfiguratorImpl so that if disableConfiguratorServices is called out of turn (ie. after a beginRequest has already been made), then a warning is logged and the services continue to run so the contract is not broken.
5. The GlobalConfiguratorImpl is documented much better and outlines the differences between it and it's ancestor, the Configurator abstract class
6. The Configurator abstract class is documented from the point of view of an "implementor" rather then from the GlobalConfiguratorImpl perspective.
7. Some other minor changes to use the API
I still have yet to check this code out in my POC environment, I hope to have that done soon so this JIRA ticket can be merged into main.
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch, 9-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-234) Filter logic for Portlets
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469146 ]
Jeanne Waldman commented on ADFFACES-234:
-----------------------------------------
Committed patch 11-ADFFACES-234. Revision 401939
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: https://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 11-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch, 9-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-234) Filter logic for Portlets
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-234?page=comments#action_12455496 ]
Jeanne Waldman commented on ADFFACES-234:
-----------------------------------------
I applied this to the jwaldman-portlet branch.
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: http://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-234) Filter logic for Portlets
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461871 ]
Jeanne Waldman commented on ADFFACES-234:
-----------------------------------------
9-ADFFACES-234.patch (35 kb), applied to jwaldman-portal branch
> Filter logic for Portlets
> -------------------------
>
> Key: ADFFACES-234
> URL: https://issues.apache.org/jira/browse/ADFFACES-234
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 1-ADFFACES-234.patch, 7-ADFFACES-234.patch, 8-ADFFACES-234.patch, 9-ADFFACES-234.patch
>
>
> The filter logic (with the exception of the wrapper objects) needs to be ported over to use the system to be provided by MYFACES-1448. See also ADFFACES-229 and ADFFACES-230
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira