You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "TaiJuWu (via GitHub)" <gi...@apache.org> on 2024/09/16 06:41:23 UTC
[PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
TaiJuWu opened a new pull request, #17208:
URL: https://github.com/apache/kafka/pull/17208
Jira: https://issues.apache.org/jira/browse/KAFKA-17542
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766061907
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Hi @mumrah , I think https://github.com/apache/kafka/pull/17208/commits/91bafe1d6015c058056978d4d5ff4acd264e04f9 meet @chia7712 requirement.
It will label "module" + "tests".
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766034189
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
> - any-glob-to-any-file: 'src/**/*'
> - all-globs-to-all-files: '!src/docs/*'
Thanks, I missed this one. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766308100
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'group-coordinator/**'
+ - 'coordinator-common/**'
+
+performance:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'jmh-benchmarks/**'
+
+consumer:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'clients/src/main/java/org/apache/kafka/clients/consumer/**'
+
+producer:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'clients/src/main/java/org/apache/kafka/clients/producer/**'
+
Review Comment:
Also, `transaction` may need a individual label too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767493632
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1764260378
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Keep this one to reminder me temporarily until I find a new method to add tests label like @chia7712 suggest.
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Keep this one to reminder me temporarily until I find a new method to add tests label like @chia7712 suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2357286322
> Left some additional comments, @TaiJuWu.
>
> I like @chia7712's suggestions. For 3 and 4, we may probably will need to do something more complex than simply using the labeler action. For example,
>
> > 3. add test label if only test code gets changed
>
> will require getting the diff of the PR and checking the file paths. This will require a script of some kind.
Yes, you are right, but the action/labeler does not support scripts. I am still investigating how to achieve this goal.
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #17208:
URL: https://github.com/apache/kafka/pull/17208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766306911
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
Review Comment:
Could you please include `log4j-appender` and `shell`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767526191
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
+
+share:
Review Comment:
This should be `KIP-932`. Rather than the the glob, let's enumerate the two exact directories `share` and `share-coordinator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2357328459
> Here is an example of using the `gh` tool within our workflows
>
> https://github.com/apache/kafka/blob/trunk/.github/actions/gh-api-update-status/action.yml
>
> It would be nice to have a reusable action similar to this for adding labels
Got it. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765954861
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Unfortunally, the tool did not so complex operation.
I have tried follow code but it does not work.
```
connect:
- changed-files:
- all-globs-to-any-file:
- 'connect/**'
- 'connect/[!mirror]*/**'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765954861
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Unfortunally, the tool did not support complex operation.
I have tried follow code but it does not work.
```
connect:
- changed-files:
- all-globs-to-any-file:
- 'connect/**'
- 'connect/[!mirror]*/**'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1762066173
##########
.github/workflows/labeler.yml:
##########
@@ -0,0 +1,12 @@
+name: "Pull Request Labeler"
+on:
+- pull_request_target
+
+jobs:
+ labeler:
+ permissions:
+ contents: read
+ pull-requests: write
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/labeler@v5
Review Comment:
Ah, that's too bad. Maybe we can enable that feature once the action has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766021173
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
If nothing else works, we can just manually specify one glob for every submodule that isn't MM2; e.g., `connect/runtime/**`, `connect/api/**`, `connect/json/**`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2354260462
@TaiJuWu thanks for this patch I believe it will be an important feature to our PR flow. I list some brainstorming below. PTAL
1. add module labels according to changed files
2. add build/ci label if build.gradle/.github related files are changed
3. add test label if only test code gets changed
4. add minor label if there are few line changes
5. add docs label if only docs get changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1763207161
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
Review Comment:
remove this one (since we have kraft below)
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+metadata:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'metadata/**'
Review Comment:
remove this one
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
remove this one
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+metadata:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'metadata/**'
+
+docs:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docs/**'
+ - '**/*.md'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+server:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*server*/**'
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*coordinator*/**'
+
+examples:
Review Comment:
how about `docs` instead?
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+metadata:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'metadata/**'
+
+docs:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docs/**'
+ - '**/*.md'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+server:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*server*/**'
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*coordinator*/**'
+
+examples:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'examples/**'
+
+benchmarks:
Review Comment:
let's use `performance`
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+metadata:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'metadata/**'
+
+docs:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docs/**'
+ - '**/*.md'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+server:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*server*/**'
Review Comment:
combine this with `core` (we don't use `server` label)
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+metadata:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'metadata/**'
+
+docs:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docs/**'
+ - '**/*.md'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+server:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*server*/**'
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - '*coordinator*/**'
Review Comment:
let's enumerate `coordinator-common` and `group-coordinator` here
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
Review Comment:
remove this one (no `config` label)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765954861
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Unfortunally, the tool did not so complex thing.
I have tried follow code but it does not work.
```
connect:
- changed-files:
- all-globs-to-any-file:
- 'connect/**'
- 'connect/[!mirror]*/**'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767524646
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'group-coordinator/**'
+ - 'coordinator-common/**'
Review Comment:
Ah, we should use KIP-932 for the share coordinator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "apoorvmittal10 (via GitHub)" <gi...@apache.org>.
apoorvmittal10 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1775487949
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,124 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transactions:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction-coordinator/**'
+
+KIP-932:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'share/**'
+ - 'share-coordinator/**'
Review Comment:
This is great thank you, I was manually tagging them @TaiJuWu 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765945378
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Yeah, it'd be nice if we could avoid that. MM2 and Connect are about as different as Connect and the clients module.
Maybe we can change the `connect` label to match any of the Connect submodules except for `connect/mirror/**`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2354154437
> `raft` and `metadata` aren't labels we currently have. You can check the existing ones here: https://github.com/apache/kafka/labels
Hi @mumrah , thanks for your review and info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2362353332
Hi @mumrah , all comments are addressed, thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1764261652
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Ok. "minor" and "tests" will complete next part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767529767
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
Review Comment:
Let's be explicit with `transaction-coordinator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765988397
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
I think the [docs](https://github.com/actions/labeler) give an example that would work for this case:
```
# Add 'source' label to any change to src files within the source dir EXCEPT for the docs sub-folder
source:
- all:
- changed-files:
- any-glob-to-any-file: 'src/**/*'
- all-globs-to-all-files: '!src/docs/*'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1764260378
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Keep this one to reminder me temporarily until I find a new method to add tests label like @chia7712 said.
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Keep this one to reminder me temporarily until I find a new method to add tests label like @chia7712 suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766303492
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'group-coordinator/**'
+ - 'coordinator-common/**'
+
+performance:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'jmh-benchmarks/**'
+
+consumer:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'clients/src/main/java/org/apache/kafka/clients/consumer/**'
+
+producer:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'clients/src/main/java/org/apache/kafka/clients/producer/**'
+
Review Comment:
Should we add `generator` label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766301743
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
Review Comment:
Could you please move this file to ./github/actions/label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2357309439
> Thanks @TaiJuWu, looks good. One minor suggestion.
>
> If we want to wait on @chia7712's more complex suggestions (i.e., "minor" label and "tests" only PRs), we can do those in a part 2 PR.
> > Yes, you are right, but the action/labeler does not support scripts
>
> We can add an additional step to evaluate the diff and determine what labels to apply. We can use octokit or `gh api` (my preference) to actually set the label.
Ok. I am happy to handle this.
Another question, does we need our bot (like apache-bot) if we need to use `gh api` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1762052084
##########
.github/workflows/labeler.yml:
##########
@@ -0,0 +1,12 @@
+name: "Pull Request Labeler"
+on:
+- pull_request_target
+
+jobs:
+ labeler:
+ permissions:
+ contents: read
+ pull-requests: write
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/labeler@v5
Review Comment:
Not sure we actually need to enable this feature.
The labeler will remove labels even if some labels are not set by it (eg. a label comes from maintainer or other bot).
You can refer https://github.com/actions/labeler/issues/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765428493
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Can we use the separate [mirror-maker-2 label](https://github.com/apache/kafka/pulls?q=is%3Apr+label%3Amirror-maker-2) for changes to `connect/mirror`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2357321567
Here is an example of using the `gh` tool within our workflows
https://github.com/apache/kafka/blob/trunk/.github/actions/gh-api-update-status/action.yml
It would be nice to have a reusable action similar to this for adding labels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765915196
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Added. But in this case, the labeler still attach connect to connect/mirror.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1761174217
##########
.github/workflows/labeler.yml:
##########
@@ -0,0 +1,12 @@
+name: "Pull Request Labeler"
+on:
+- pull_request_target
Review Comment:
Let's enumerate the events we want to use as triggers to avoid unnecessary runs. Probably: opened, reopened, and synchronized (i.e., when someone pushes to the PR)
##########
.github/workflows/labeler.yml:
##########
@@ -0,0 +1,12 @@
+name: "Pull Request Labeler"
+on:
+- pull_request_target
+
+jobs:
+ labeler:
+ permissions:
+ contents: read
+ pull-requests: write
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/labeler@v5
Review Comment:
There is a "sync" option we should use. This will allow the labeler to remove labels as well (when the file set changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766969808
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
Review Comment:
sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767705623
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,124 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
Review Comment:
Done. Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1764257400
##########
.github/workflows/labeler.yml:
##########
@@ -0,0 +1,14 @@
+name: "Pull Request Labeler"
+on:
+ pull_request_target:
+ types: [opened, reopened, synchronize]
+
+
+jobs:
+ labeler:
Review Comment:
naming: "label PRs" ?
##########
.github/labeler.yml:
##########
@@ -0,0 +1,86 @@
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+docs:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'group-coordinator/**'
+ - 'coordinator-common/**'
+
+performance:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'jmh-benchmarks/**'
+
+consumer:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'clients/src/main/java/org/apache/kafka/clients/consumer/**'
+
+producer:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'clients/src/main/java/org/apache/kafka/clients/producer/**'
+
+kraft:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'metadata/**'
+ - 'raft/**'
Review Comment:
nit: add newline at end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1764264267
##########
.github/workflows/labeler.yml:
##########
@@ -0,0 +1,14 @@
+name: "Pull Request Labeler"
+on:
+ pull_request_target:
+ types: [opened, reopened, synchronize]
+
+
+jobs:
+ labeler:
Review Comment:
I named to label_PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766061907
##########
.github/labeler.yml:
##########
@@ -0,0 +1,99 @@
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+config:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'config/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+
+raft:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'raft/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tests:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tests/**'
Review Comment:
Hi @mumrah , I think https://github.com/apache/kafka/pull/17208/commits/91bafe1d6015c058056978d4d5ff4acd264e04f9 meet @chia7712 requirement.
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767527139
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
+
+share:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '*share*/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
Review Comment:
This is not a label. Let's remove this one. We can let the developers working on these areas propose their own globs and labels
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
+
+share:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '*share*/**'
+
+docker:
Review Comment:
This label didn't exist, but it should have. I created it.
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
Review Comment:
Let's remove this one. There's no label for this module
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
+
+share:
Review Comment:
This should be `kip-932`. Rather than the the glob, let's enumerate the two exact directories `share` and `share-coordinator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1765915196
##########
.github/labeler.yml:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+connect:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**'
Review Comment:
Added. But in this case, the labeler still attach connect label to connect/mirror.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17208:
URL: https://github.com/apache/kafka/pull/17208#issuecomment-2357305239
> Yes, you are right, but the action/labeler does not support scripts
We can add an additional step to evaluate the diff and determine what labels to apply. We can use octokit or `gh api` (my preference) to actually set the label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766305374
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'group-coordinator/**'
+ - 'coordinator-common/**'
Review Comment:
Could you add `share`-related folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1766796027
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
Review Comment:
`.github/labeler.yml` is the default location for this config file. If we don't like it at the root of `.github`, i'd suggest `.github/config/labeler.yml`. Note that we'll need to set this path in the action https://github.com/actions/labeler?tab=readme-ov-file#inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767529767
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'transaction*/**'
Review Comment:
Let's be explicit with `transaction-coordinator`. Also, I created the label as `transactions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767700031
##########
.github/configs/labeler.yml:
##########
@@ -0,0 +1,124 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+ - 'log4j-appender/**'
+ - 'shell/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+generator:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'generator/**'
+
+transaction:
Review Comment:
nit: `transactions` (plural)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #17208:
URL: https://github.com/apache/kafka/pull/17208#discussion_r1767491586
##########
.github/labeler.yml:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+build:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+ - 'gradle/**'
+ - '*gradlew*'
+
+clients:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'clients/**'
+
+
+tests:
+- all:
+ - changed-files:
+ - any-glob-to-all-files:
+ - 'tests/**'
+ - '**/test/**'
+
+
+connect:
+- all:
+ - changed-files:
+ - any-glob-to-any-file:
+ - 'connect/**/*'
+ - all-globs-to-all-files:
+ - '!connect/mirror/*'
+
+mirror-maker-2:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'connect/mirror/**'
+
+core:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'core/**'
+ - '*server*/**'
+
+storage:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'storage/**'
+
+streams:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'streams/**'
+
+tools:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'tools/**'
+ - 'trogdor/**'
+ - 'vagrant/**'
+ - 'committer-tools/**'
+
+docs:
+- changed-files:
+ - any-glob-to-all-files:
+ - 'docs/**'
+ - '**/*.md'
+ - 'examples/**'
+
+docker:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'docker/**'
+
+
+coordinator:
+- changed-files:
+ - any-glob-to-any-file:
+ - 'group-coordinator/**'
+ - 'coordinator-common/**'
Review Comment:
Hi @chia7712 ,
All comments are addressed in 80bfa4a2f54923f0f07f8195040147e52a3db85a
There is a special case `share-coordinator`, should we put `share` or `coordinator` to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org