You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Stefan Huehner (JIRA)" <ji...@apache.org> on 2006/12/12 03:29:21 UTC
[jira] Created: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
JavaMailContainer is broken for all password not consisting of only lowercase characters
----------------------------------------------------------------------------------------
Key: OFBIZ-543
URL: http://issues.apache.org/jira/browse/OFBIZ-543
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Stefan Huehner
Priority: Critical
Attachments: ofbiz_mail1.diff
Hi,
after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Stefan Huehner (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=all ]
Stefan Huehner updated OFBIZ-543:
---------------------------------
Attachment: ofbiz_mail1.diff
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=comments#action_12459183 ]
David E. Jones commented on OFBIZ-543:
--------------------------------------
This fix looks fine to me, and just fixes what looks like it really is a bug.
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=all ]
Jacques Le Roux closed OFBIZ-543.
---------------------------------
Fix Version/s: SVN trunk
Resolution: Fixed
Thanks Stefan,
Your patch is in OFBiz revision: 488137
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Fix For: SVN trunk
>
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=comments#action_12459112 ]
Jacques Le Roux commented on OFBIZ-543:
---------------------------------------
OK for everybody (no response is an OK here...) ?
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=comments#action_12458285 ]
Jacques Le Roux commented on OFBIZ-543:
---------------------------------------
This patch seems good to me. If nobody complains I'm ready to apply it...
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=comments#action_12459128 ]
Jacques Le Roux commented on OFBIZ-543:
---------------------------------------
Jacopo,
Yes I saw the tab, waiting a little bit more...
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=all ]
Jacques Le Roux reassigned OFBIZ-543:
-------------------------------------
Assignee: Jacques Le Roux
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-543) JavaMailContainer is broken for all
password not consisting of only lowercase characters
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-543?page=comments#action_12459114 ]
Jacopo Cappellato commented on OFBIZ-543:
-----------------------------------------
I'm not an expert of this area but it looks good.
There is just one little formatting issue: one tab in the first code chunk...
> JavaMailContainer is broken for all password not consisting of only lowercase characters
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-543
> URL: http://issues.apache.org/jira/browse/OFBIZ-543
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacques Le Roux
> Priority: Critical
> Attachments: ofbiz_mail1.diff
>
>
> Hi,
> after 2 hours of debugging the JavaMailContainer and working with javamail properties and network traces i noticed that when creating the JavaMail session the Container transforms all property names and ALL property values (including the password) to lowercase. Thus authentication fails if the password does contain uppercase characters.
> The attached patch removes the conversion of property values to lowercase altogether, which fixes the issue. As i see no pressing issue to convert other property-values to lowercase i chose this way instead of excluding only selected properties.
> The second change to the Container prints out the Text of the exception which has occured when reporting that the mail store could not be opened to give the user a clue about the source (i.e. SSL trust chain verification problem).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira