[GitHub] [hbase] saintstack commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4

[GitBox <gi...@apache.org>]

saintstack commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4
URL: https://github.com/apache/hbase/pull/1186#issuecomment-589167383
 
 
   > The biggest problem is that LiteralByteString is a private inner class now, so it cannot be extended.
   
   Is this recent or it is this just an old change? (I think the latter, right?)
   
   > And since HBaseZeroCopyByteString is annotated with @InterfaceAudience.Private I assume that it should not be used by others.
   
   That is correct and if private, you could just remove it rather than try and make it work w/ new PB ..... but is it not used by ByteStringer ? Also private but internally has a flag set to true on whether to use HBaseZeroCopyByteString ?  (If not available or failed construct, we fall back to false).
   
   This HBaseZeroCopyByteString is from a different time. I've not looked in a while but is there an alternative means of zero copy in pb?  See UnsafeByteOperations ? Also, IIRC, we actually patch our pb (see build over in hbase-thirdparty). Can add a patch if it'd help.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services