You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/13 08:38:47 UTC
Review Request 30978: Updated documentation for explicit
acknowledgement API change.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
Bugs: MESOS-2347
https://issues.apache.org/jira/browse/MESOS-2347
Repository: mesos
Description
-------
This updates the CHANGELOG and upgrades document for the upcoming API change.
Diffs
-----
CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
Diff: https://reviews.apache.org/r/30978/diff/
Testing
-------
N/A
Thanks,
Ben Mahler
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/#review72365
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30969, 30970, 30971, 30972, 30973, 30974, 30976, 30977, 30978]
All tests passed.
- Mesos ReviewBot
On Feb. 13, 2015, 7:38 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30978/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 7:38 a.m.)
>
>
> Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
>
>
> Bugs: MESOS-2347
> https://issues.apache.org/jira/browse/MESOS-2347
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates the CHANGELOG and upgrades document for the upcoming API change.
>
>
> Diffs
> -----
>
> CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
> docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
> docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
>
> Diff: https://reviews.apache.org/r/30978/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/#review73213
-----------------------------------------------------------
Ship it!
CHANGELOG
<https://reviews.apache.org/r/30978/#comment119453>
s/,;/
CHANGELOG
<https://reviews.apache.org/r/30978/#comment119455>
s/StatusUpdate/TaskStatus/ ?
- Vinod Kone
On Feb. 18, 2015, 11:44 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30978/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:44 p.m.)
>
>
> Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
>
>
> Bugs: MESOS-2347
> https://issues.apache.org/jira/browse/MESOS-2347
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates the CHANGELOG and upgrades document for the upcoming API change.
>
>
> Diffs
> -----
>
> CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
> docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
> docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
>
> Diff: https://reviews.apache.org/r/30978/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/
-----------------------------------------------------------
(Updated Feb. 21, 2015, 10:26 p.m.)
Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
Changes
-------
* Updated `acknowledgeStatusUpdate` to take a `TaskStatus` to simplify the call for schedulers.
Bugs: MESOS-2347
https://issues.apache.org/jira/browse/MESOS-2347
Repository: mesos
Description
-------
This updates the CHANGELOG and upgrades document for the upcoming API change.
Diffs (updated)
-----
CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
Diff: https://reviews.apache.org/r/30978/diff/
Testing
-------
N/A
Thanks,
Ben Mahler
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/#review73065
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30970, 30971, 30972, 30973, 30974, 30976, 30977, 30978]
All tests passed.
- Mesos ReviewBot
On Feb. 18, 2015, 11:44 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30978/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:44 p.m.)
>
>
> Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
>
>
> Bugs: MESOS-2347
> https://issues.apache.org/jira/browse/MESOS-2347
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates the CHANGELOG and upgrades document for the upcoming API change.
>
>
> Diffs
> -----
>
> CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
> docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
> docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
>
> Diff: https://reviews.apache.org/r/30978/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 11:44 p.m.)
Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
Changes
-------
* Scheduler interface updated to reflect '`uuid`' presence as a signal for acknowledgments.
Bugs: MESOS-2347
https://issues.apache.org/jira/browse/MESOS-2347
Repository: mesos
Description
-------
This updates the CHANGELOG and upgrades document for the upcoming API change.
Diffs (updated)
-----
CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
Diff: https://reviews.apache.org/r/30978/diff/
Testing
-------
N/A
Thanks,
Ben Mahler
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/
-----------------------------------------------------------
(Updated Feb. 17, 2015, 6 a.m.)
Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
Changes
-------
* Updates per the removal of the signature change on the API.
Bugs: MESOS-2347
https://issues.apache.org/jira/browse/MESOS-2347
Repository: mesos
Description
-------
This updates the CHANGELOG and upgrades document for the upcoming API change.
Diffs (updated)
-----
CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
Diff: https://reviews.apache.org/r/30978/diff/
Testing
-------
N/A
Thanks,
Ben Mahler
Re: Review Request 30978: Updated documentation for explicit
acknowledgement API change.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30978/#review72394
-----------------------------------------------------------
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/30978/#comment118461>
>persisted durably by the scheduler
This is just a suggestion rather than a requirement, right? Persisting status updates may be prohibitively expensive for a scheduler using native Mesos log. Is there a way for the master to fully guarantee reliable delivery of status updates in view of ack timeouts?
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/30978/#comment118462>
No docs for the `acknowledgeStatusUpdate` API?
- Maxim Khutornenko
On Feb. 13, 2015, 7:38 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30978/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 7:38 a.m.)
>
>
> Review request for mesos, Niklas Nielsen, Vinod Kone, and Bill Farner.
>
>
> Bugs: MESOS-2347
> https://issues.apache.org/jira/browse/MESOS-2347
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates the CHANGELOG and upgrades document for the upcoming API change.
>
>
> Diffs
> -----
>
> CHANGELOG 966661ab5790a5297736121dd7189b4b4131efd6
> docs/app-framework-development-guide.md e6247b23de3aebbe911a2f72839710c7477008fe
> docs/upgrades.md 168e761b7242dc421ff6c7748e2c735de07ab87c
>
> Diff: https://reviews.apache.org/r/30978/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>