[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #6257: Bugfix: Bring back singleton option when creating a new Session Bean and interfaceless EJBs

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on code in PR #6257:
URL: https://github.com/apache/netbeans/pull/6257#discussion_r1274120702


##########
enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/api/methodcontroller/EjbMethodController.java:
##########
@@ -72,7 +72,7 @@ public EjbType run(EjbJarMetadata metadata) throws Exception {
                 Project project = FileOwnerQuery.getOwner(ejbClassFO);
                 if (project != null){
                     J2eeProjectCapabilities projectCap = J2eeProjectCapabilities.forProject(project);
-                    allowsNoInterface = projectCap != null ? projectCap.isEjb31LiteSupported() : false;
+                    allowsNoInterface = (projectCap != null && (projectCap.isEjb31LiteSupported() || projectCap.isEjb40LiteSupported()));

Review Comment:
   My reading of `isEjb31LiteSupported` is, that it is `true` if EJB 3.2 is supported. Assuming EJB follows the convention, that breaking changes are communicated by a change in the major number, this makes sense (repeating myself: I assume 3.2 is a superset of 3.1).
   Yes if `isEjb31Supported` returns `true`, `isEjb31LiteSupported` will, the same is true for the other EJB capability checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists