You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/10/16 02:14:44 UTC

[jira] Created: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

update java example doc to compile with latest zookeeper
--------------------------------------------------------

                 Key: ZOOKEEPER-193
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
             Project: Zookeeper
          Issue Type: Bug
          Components: documentation
    Affects Versions: 3.0.0
            Reporter: Patrick Hunt
            Assignee: Patrick Hunt
             Fix For: 3.0.0


In particular the pkg structure has changed.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640493#action_12640493 ] 

Hudson commented on ZOOKEEPER-193:
----------------------------------

Integrated in ZooKeeper-trunk #116 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/116/])
    . update java example doc to compile with latest zookeeper


> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-193.patch, ZOOKEEPER-193.patch
>
>
> In particular the pkg structure has changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-193:
-----------------------------------

    Attachment: ZOOKEEPER-193.patch

fixes the example code to build with zk3

> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-193.patch
>
>
> In particular the pkg structure has changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640180#action_12640180 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-193:
--------------------------------------------------

+1, it looks good. Just a few minor comments:

1- I'm not sure why logical and symbols show up with "amp": 
               
                 if (path != null &amp;&amp; path.equals(znode))

    The same happens here:
                 
                 List&lt;String&gt; list = zk.getChildren(root, true);

   It is probably some problem with the character representation, and I guess this is due to downloading/uploading the patch via http, but interestingly this is the first time I see such a problem with our patches.

2-  We can remove the following commented lines:
   
                +        //else mutex = new Integer(-1);

                +            //System.out.println("Process: " + event.getType());


> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-193.patch, ZOOKEEPER-193.patch
>
>
> In particular the pkg structure has changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-193:
-----------------------------------

    Attachment: ZOOKEEPER-193.patch

this updated patch cleans up the tutorial as well.

> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-193.patch, ZOOKEEPER-193.patch
>
>
> In particular the pkg structure has changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-193:
-----------------------------------

    Status: Patch Available  (was: Open)

> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-193.patch
>
>
> In particular the pkg structure has changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-193) update java example doc to compile with latest zookeeper

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-193:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed revision 705346.

> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-193.patch, ZOOKEEPER-193.patch
>
>
> In particular the pkg structure has changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.