You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/04/25 15:36:22 UTC

[jira] [Commented] (BOOKKEEPER-224) Fix findbugs in bookkeeper-server component

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261638#comment-13261638 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-224:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4873/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

Fix findbugs in bookkeeper-server component


This addresses bug BOOKKEEPER-224.
    https://issues.apache.org/jira/browse/BOOKKEEPER-224


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 947ba6a 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieException.java 714f70f 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 97e01c0 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java e737055 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 269581a 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java 65d6947 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java eb8a89e 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerEntryPage.java 294684a 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java b9cd624 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java a5bb426 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java f0a165f 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java c5687ae 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java 950fba2 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java a564536 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java 3c225c6 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 8fd7df8 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java 3a3a81e 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java b62ad3a 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java f02d838 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java 3dfb67d 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 2ee9cb4 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java e5eea00 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/util/HardLink.java 6e6c3e7 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java 1d47643 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/NIOServerFactoryTest.java e2b2758 

Diff: https://reviews.apache.org/r/4873/diff


Testing
-------


Thanks,

Ivan


                
> Fix findbugs in bookkeeper-server component
> -------------------------------------------
>
>                 Key: BOOKKEEPER-224
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-224
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-224.diff
>
>
> fix Findbugs warnings for bookkeeper-server

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira