You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/04/04 16:13:35 UTC
[GitHub] [zookeeper] amichair opened a new pull request #1672: ZOOKEEPER-3754: Add OSGi support
amichair opened a new pull request #1672:
URL: https://github.com/apache/zookeeper/pull/1672
Added the maven bundle plugin to the pom, and an OSGi integration test (pax exam) to make sure it really works.
Before merging this I just want to verify a couple things with the devs:
1. The dependencies marked as optional vs required are correct.
2. The zookeeper-jute dependency module seems to contain the same package names as the zookeeper-server module, which is bad practice in general and troublesome in OSGi in particular. I'm not sure what jute is, but to avoid issues I thought maybe it's better to embed it within the server bundle rather than import it as an external dependency (via the Embed-Dependency configuration)... what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] amichair commented on pull request #1672: ZOOKEEPER-3754: Add OSGi support
Posted by GitBox <gi...@apache.org>.
amichair commented on pull request #1672:
URL: https://github.com/apache/zookeeper/pull/1672#issuecomment-886193329
The benefit is that it will be usable out of the box when dropped into any OSGi container, without forking and wrapping and such, as it used to be before this regression, and as many other apache and other projects are. OSGi isn't going anywhere afaik - the spec and implementations are still under active development. It's more than just module management... it's a whole container full of services and featuers. I suppose the Aries and Karaf projects can sell you on its usefulness better than I can :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1672: ZOOKEEPER-3754: Add OSGi support
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1672:
URL: https://github.com/apache/zookeeper/pull/1672#issuecomment-872954834
@amichair Sorry for our late, Please forgive my ignorance and stupid:
- What's the benefit to add `OSGi` support?
- `OSGi` seems a little out-of-date, heavy-weight one, and `jigsaw` becomes the trending?
> Before merging this I just want to verify a couple things with the devs:
@nkalmar @eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org