[GitHub] [lucenenet] NightOwl888 commented on issue #413: Making Lucene.Net.Join.TermsQuery public

[GitBox <gi...@apache.org>]

NightOwl888 commented on issue #413:
URL: https://github.com/apache/lucenenet/issues/413#issuecomment-955974419


   @sthmathew 
   
   I finally got a chance to [ask the Lucene team whether this would be something they would consider](https://lists.apache.org/thread.html/r3eb924dd01d468d9b911177f8caff01330d38e76257d71c5e6392829%40%3Cdev.lucene.apache.org%3E), and it turns out that `TermsQuery` from the `queries` package "provides similar functionality" and furthermore it has been transferred to the `core` package in https://github.com/apache/lucene/commit/22940f5c49297b606d710c6775309d67ff064f2f.
   
   So, there are a couple of ways this could go:
   
   1. You could port over one of the public versions from 5.2 or from a later version for use in your application. However, in the current version there are some Automaton dependencies that don't exist in 4.8.0, so you will need to pick a version before that point.
   2. We could make `Lucene.Net.Join.TermsQuery` public in 4.8.0 and you will need to adjust your code when Lucene.NET is upgraded to a newer version to call the public implementation, since `Lucene.Net.Join.TermsQuery` will be made internal again at the time of the upgrade. It doesn't make much sense to have 2 public queries that are similar.
   
   I suspect the public `TermsQuery` was probably optimized a little better, so you might want to try porting it to see how that goes and report back whether that will work for you.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org