You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ahmedsobeh (via GitHub)" <gi...@apache.org> on 2024/02/22 14:54:44 UTC
[PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]
ahmedsobeh opened a new pull request, #15421:
URL: https://github.com/apache/kafka/pull/15421
For RocksDB stores, we open the store first and then call #register. However the in-memory store actually registers itself first, before marking itself as open. This change aligns the RocksDB init sequence with that off the in-memory stores by moving the store opening to be after registration
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15421:
URL: https://github.com/apache/kafka/pull/15421#issuecomment-2571488522
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15421: KAFKA-16295: Align RocksDB and in-memory store init() sequences
URL: https://github.com/apache/kafka/pull/15421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]
Posted by "wcarlson5 (via GitHub)" <gi...@apache.org>.
wcarlson5 commented on code in PR #15421:
URL: https://github.com/apache/kafka/pull/15421#discussion_r1520361134
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -170,9 +170,6 @@ public void init(final ProcessorContext context,
@Override
public void init(final StateStoreContext context,
final StateStore root) {
- // open the DB dir
- metricsRecorder.init(getMetricsImpl(context), context.taskId());
- openDB(context.appConfigs(), context.stateDir());
Review Comment:
Can we get one more line deleted here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15421:
URL: https://github.com/apache/kafka/pull/15421#issuecomment-2157136573
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org