You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@vmware.com> on 2020/09/23 23:22:52 UTC

[PROPOSAL] Backport usability improvements to support 1.13 branch

Hello,

I’d like to merge the pull request: https://github.com/apache/geode/pull/5524 into a support 1.13 branch.  The commits are focused on a few usability improvements for Geode that were thought to have made it into 1.13 but actually did not make it.

What this pull request back ports:

  *   GEODE-8203: Logging to std out along with to the regular log file
  *   GEODE-8283: Rest API for disk store creation
  *   GEODE-8200: Fix for Rebalance API stuck “IN_PROGRESS” state forever and GEODE-8200: Enhance GfshRule
  *   GEODE-8241: Locator observers locator-wait-time
  *   GEODE-8078: Log and report error at the correct place


The PR pipeline is failing due to Redis tests (that I don’t think are on 1.13).  Everything else appears to be passing.

Thanks,
-Jason

Re: [PROPOSAL] Backport usability improvements to support 1.13 branch

Posted by Dan Smith <da...@vmware.com>.
+1 - I had a question on the PR itself about how we're merging these.

-Dan
________________________________
From: Joris Melchior <jm...@vmware.com>
Sent: Thursday, September 24, 2020 8:13 AM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: [PROPOSAL] Backport usability improvements to support 1.13 branch

+1

On 2020-09-23, 7:23 PM, "Jason Huynh" <jh...@vmware.com> wrote:

    Hello,

    I’d like to merge the pull request: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5524&amp;data=02%7C01%7Cdasmith%40vmware.com%7C07a555320cbd4d6f943a08d8609c7569%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637365572383970684&amp;sdata=qfpuzsR8VdYuv1GS3KKHVztAFX0S5yVITEW8b6oigoQ%3D&amp;reserved=0 into a support 1.13 branch.  The commits are focused on a few usability improvements for Geode that were thought to have made it into 1.13 but actually did not make it.

    What this pull request back ports:

      *   GEODE-8203: Logging to std out along with to the regular log file
      *   GEODE-8283: Rest API for disk store creation
      *   GEODE-8200: Fix for Rebalance API stuck “IN_PROGRESS” state forever and GEODE-8200: Enhance GfshRule
      *   GEODE-8241: Locator observers locator-wait-time
      *   GEODE-8078: Log and report error at the correct place


    The PR pipeline is failing due to Redis tests (that I don’t think are on 1.13).  Everything else appears to be passing.

    Thanks,
    -Jason

Re: [PROPOSAL] Backport usability improvements to support 1.13 branch

Posted by Joris Melchior <jm...@vmware.com>.
+1

On 2020-09-23, 7:23 PM, "Jason Huynh" <jh...@vmware.com> wrote:

    Hello,

    I’d like to merge the pull request: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5524&amp;data=02%7C01%7Cjmelchior%40vmware.com%7Cf627e716175e47d617c408d86017a1be%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637365001914345788&amp;sdata=Tbd%2FUTlqEmiEiq%2BlCo2IGsGeNA7GO40XlowwRV9Bq9Y%3D&amp;reserved=0 into a support 1.13 branch.  The commits are focused on a few usability improvements for Geode that were thought to have made it into 1.13 but actually did not make it.

    What this pull request back ports:

      *   GEODE-8203: Logging to std out along with to the regular log file
      *   GEODE-8283: Rest API for disk store creation
      *   GEODE-8200: Fix for Rebalance API stuck “IN_PROGRESS” state forever and GEODE-8200: Enhance GfshRule
      *   GEODE-8241: Locator observers locator-wait-time
      *   GEODE-8078: Log and report error at the correct place


    The PR pipeline is failing due to Redis tests (that I don’t think are on 1.13).  Everything else appears to be passing.

    Thanks,
    -Jason

Re: [PROPOSAL] Backport usability improvements to support 1.13 branch

Posted by Owen Nichols <on...@vmware.com>.
Correct, the Redis job in the PR pipeline is for 1.14 and later, please ignore that failure on 1.13 PRs.

As there is not currently an active release on support/1.13, you are free to backport these at any time with or without votes, but thanks for highlighting that these didn't make it into 1.13.0.

Please ensure the Fixed version for all five of these contain both 1.14.0 and 1.13.1 in Jira, thanks!  +1

On 9/23/20, 4:38 PM, "Nabarun Nag" <nn...@vmware.com> wrote:

    +1
    ________________________________
    From: Jason Huynh <jh...@vmware.com>
    Sent: Wednesday, September 23, 2020 4:22 PM
    To: dev@geode.apache.org <de...@geode.apache.org>
    Subject: [PROPOSAL] Backport usability improvements to support 1.13 branch

    Hello,

    I’d like to merge the pull request: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5524&amp;data=02%7C01%7Conichols%40vmware.com%7C8d99b0330a044036063908d86019bfde%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637365011015797103&amp;sdata=rSHXQYXhQT3jibMSNCxcxNL6b4p6LEA9LHBA9AdfXkA%3D&amp;reserved=0 into a support 1.13 branch.  The commits are focused on a few usability improvements for Geode that were thought to have made it into 1.13 but actually did not make it.

    What this pull request back ports:

      *   GEODE-8203: Logging to std out along with to the regular log file
      *   GEODE-8283: Rest API for disk store creation
      *   GEODE-8200: Fix for Rebalance API stuck “IN_PROGRESS” state forever and GEODE-8200: Enhance GfshRule
      *   GEODE-8241: Locator observers locator-wait-time
      *   GEODE-8078: Log and report error at the correct place


    The PR pipeline is failing due to Redis tests (that I don’t think are on 1.13).  Everything else appears to be passing.

    Thanks,
    -Jason

Re: [PROPOSAL] Backport usability improvements to support 1.13 branch

Posted by Nabarun Nag <nn...@vmware.com>.
+1
________________________________
From: Jason Huynh <jh...@vmware.com>
Sent: Wednesday, September 23, 2020 4:22 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: [PROPOSAL] Backport usability improvements to support 1.13 branch

Hello,

I’d like to merge the pull request: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5524&amp;data=02%7C01%7Cnnag%40vmware.com%7Cc4fb6d3fd211433f8a1408d86017a2b4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637365001921254357&amp;sdata=wHr0IaJgsKVpZaWTH6SAqtunaD5WwVn1SAvuOnVgHQg%3D&amp;reserved=0 into a support 1.13 branch.  The commits are focused on a few usability improvements for Geode that were thought to have made it into 1.13 but actually did not make it.

What this pull request back ports:

  *   GEODE-8203: Logging to std out along with to the regular log file
  *   GEODE-8283: Rest API for disk store creation
  *   GEODE-8200: Fix for Rebalance API stuck “IN_PROGRESS” state forever and GEODE-8200: Enhance GfshRule
  *   GEODE-8241: Locator observers locator-wait-time
  *   GEODE-8078: Log and report error at the correct place


The PR pipeline is failing due to Redis tests (that I don’t think are on 1.13).  Everything else appears to be passing.

Thanks,
-Jason