[GitHub] [rocketmq-client-go] victory460 opened a new pull request #753: change argument to pointer-like to avoid allocations

[GitBox <gi...@apache.org>]

victory460 opened a new pull request #753:
URL: https://github.com/apache/rocketmq-client-go/pull/753


   Signed-off-by: xuweiwei <xu...@cmss.chinamobile.com>
   
   ## What is the purpose of the change
   
   #752
   
   ## Brief changelog
   
   headerPool.Put(&d) -> headerPool.Put(&d)
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #753: change argument to pointer-like to avoid allocations

[GitBox <gi...@apache.org>]

wenfengwang commented on pull request #753:
URL: https://github.com/apache/rocketmq-client-go/pull/753#issuecomment-994621734


   According to the community specifications, each PR must be related to an issue. So, you should create an issue first, and link to this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] victory460 commented on pull request #753: change argument to pointer-like to avoid allocations

[GitBox <gi...@apache.org>]

victory460 commented on pull request #753:
URL: https://github.com/apache/rocketmq-client-go/pull/753#issuecomment-994623478


   > According to the community specifications, each PR must be related to an issue. So, you should create an issue first, and link to this PR.
   
   #752 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang merged pull request #753: [ISSUE #752] change argument to pointer-like to avoid allocations

[GitBox <gi...@apache.org>]

wenfengwang merged pull request #753:
URL: https://github.com/apache/rocketmq-client-go/pull/753


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org