You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ni...@planet.nl on 2007/12/20 13:17:59 UTC

Bugs in maven-plugin-testing-harness

Hi,

I am writing a rule for the enforcer plugin and was using the maven-plugin-testing-harness classes. (Just like the testing code for the other rules)

Now I've found two small bugs in this code. Is this still maintained? The website [1] hasn't been updated for more then a year, but there have been recent changes in the source code. (The URL on the website doesn't comply with the actual subversion repository)

The two bugs are in the ArtifactStubFactory:

1)
Artifact artifact = new ArtifactStubFactory().getReleaseArtifact();
artifact.isRelease() returns false.

2)
ArtifactStubFactory stub = new ArtifactStubFactory();
stub.isCreateFiles() returns false.
stub.setFile(stub.getReleaseArtifact()); throws exception (The workingDir must be set if createFiles is true) but createFiles is false.
The last one is used by the StubArtifactResolver.

Another question as the latest How and when is this project being released?

With regards,

Nick Stolwijk

[1] http://maven.apache.org/shared/maven-plugin-testing-harness/

Re: Bugs in maven-plugin-testing-harness

Posted by Brett Porter <br...@apache.org>.
On 30/12/2007, at 2:44 PM, Brian E. Fox wrote:

> Hi Nick, I'm working on fixing these issues. I was unaware that the
> harness got moved to a new tlp "plugin-tools"
>
> They all now have a common version, so it's more complicated to  
> release
> this. Anyone know why this was moved? (Brett?)

Just thought it made sense to bring all the plugin related tools  
together.

> Why not the
> plugin-testing-tools too?

It was...
http://mail-archives.apache.org/mod_mbox/maven-dev/200710.mbox/%3c65C9986A-27F0-4812-9595-7D02A4FF9D0B@apache.org%3e
so it could probably be moved now.

Currently, I'm focusing on making the plugin testing landscape a bit  
clearer. As we reduce some of the duplication hopefully it'll make  
more sense where each thing should really live.

Cheers,
Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: Bugs in maven-plugin-testing-harness

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
Hi Nick, I'm working on fixing these issues. I was unaware that the
harness got moved to a new tlp "plugin-tools" 

They all now have a common version, so it's more complicated to release
this. Anyone know why this was moved? (Brett?) Why not the
plugin-testing-tools too?

--Brian

-----Original Message-----
From: Brian E. Fox [mailto:brianf@reply.infinity.nu] 
Sent: Thursday, December 20, 2007 10:03 AM
To: Maven Developers List
Subject: RE: Bugs in maven-plugin-testing-harness

Hi Nick,
That factory came from the dependency plugin so I'll fix the bugs. I
need to release it anyway before I can do the next dependency release.

--Brian

-----Original Message-----
From: nicklist@planet.nl [mailto:nicklist@planet.nl] 
Sent: Thursday, December 20, 2007 7:18 AM
To: dev@maven.apache.org
Subject: Bugs in maven-plugin-testing-harness

Hi,

I am writing a rule for the enforcer plugin and was using the
maven-plugin-testing-harness classes. (Just like the testing code for
the other rules)

Now I've found two small bugs in this code. Is this still maintained?
The website [1] hasn't been updated for more then a year, but there have
been recent changes in the source code. (The URL on the website doesn't
comply with the actual subversion repository)

The two bugs are in the ArtifactStubFactory:

1)
Artifact artifact = new ArtifactStubFactory().getReleaseArtifact();
artifact.isRelease() returns false.

2)
ArtifactStubFactory stub = new ArtifactStubFactory();
stub.isCreateFiles() returns false.
stub.setFile(stub.getReleaseArtifact()); throws exception (The
workingDir must be set if createFiles is true) but createFiles is false.
The last one is used by the StubArtifactResolver.

Another question as the latest How and when is this project being
released?

With regards,

Nick Stolwijk

[1] http://maven.apache.org/shared/maven-plugin-testing-harness/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: Bugs in maven-plugin-testing-harness

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
Hi Nick,
That factory came from the dependency plugin so I'll fix the bugs. I
need to release it anyway before I can do the next dependency release.

--Brian

-----Original Message-----
From: nicklist@planet.nl [mailto:nicklist@planet.nl] 
Sent: Thursday, December 20, 2007 7:18 AM
To: dev@maven.apache.org
Subject: Bugs in maven-plugin-testing-harness

Hi,

I am writing a rule for the enforcer plugin and was using the
maven-plugin-testing-harness classes. (Just like the testing code for
the other rules)

Now I've found two small bugs in this code. Is this still maintained?
The website [1] hasn't been updated for more then a year, but there have
been recent changes in the source code. (The URL on the website doesn't
comply with the actual subversion repository)

The two bugs are in the ArtifactStubFactory:

1)
Artifact artifact = new ArtifactStubFactory().getReleaseArtifact();
artifact.isRelease() returns false.

2)
ArtifactStubFactory stub = new ArtifactStubFactory();
stub.isCreateFiles() returns false.
stub.setFile(stub.getReleaseArtifact()); throws exception (The
workingDir must be set if createFiles is true) but createFiles is false.
The last one is used by the StubArtifactResolver.

Another question as the latest How and when is this project being
released?

With regards,

Nick Stolwijk

[1] http://maven.apache.org/shared/maven-plugin-testing-harness/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org