You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/05/26 15:10:50 UTC

commons-pool git commit: Use final.

Repository: commons-pool
Updated Branches:
  refs/heads/master 111f9d757 -> 7411f1083


Use final.

Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/7411f108
Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/7411f108
Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/7411f108

Branch: refs/heads/master
Commit: 7411f1083ed3fb4fc8277a28205e9530d6bf1a46
Parents: 111f9d7
Author: Gary Gregory <ga...@gmail.com>
Authored: Sat May 26 09:10:43 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Sat May 26 09:10:43 2018 -0600

----------------------------------------------------------------------
 src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java | 2 +-
 .../org/apache/commons/pool2/impl/BaseGenericObjectPool.java     | 4 ++--
 src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java   | 2 +-
 src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java   | 2 +-
 .../java/org/apache/commons/pool2/impl/NoOpCallStackTest.java    | 4 ++--
 5 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-pool/blob/7411f108/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java b/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
index 24b27fb..3f87d04 100644
--- a/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
+++ b/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
@@ -202,7 +202,7 @@ public class AbandonedConfig {
      * @see #getRequireFullStackTrace()
      * @since 2.5
      */
-    public void setRequireFullStackTrace(boolean requireFullStackTrace) {
+    public void setRequireFullStackTrace(final boolean requireFullStackTrace) {
         this.requireFullStackTrace = requireFullStackTrace;
     }
 

http://git-wip-us.apache.org/repos/asf/commons-pool/blob/7411f108/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
index 741950e..1150b0f 100644
--- a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
@@ -598,7 +598,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject {
      *            the eviction policy for this pool.
      * @since 2.6.0
      */
-    public void setEvictionPolicy(EvictionPolicy<T> evictionPolicy) {
+    public void setEvictionPolicy(final EvictionPolicy<T> evictionPolicy) {
         this.evictionPolicy = evictionPolicy;
     }
 
@@ -1113,7 +1113,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject {
         }
 
 
-        void setScheduledFuture(ScheduledFuture<?> scheduledFuture) {
+        void setScheduledFuture(final ScheduledFuture<?> scheduledFuture) {
             this.scheduledFuture = scheduledFuture;
         }
 

http://git-wip-us.apache.org/repos/asf/commons-pool/blob/7411f108/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java b/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
index bc0a5ff..93649fd 100644
--- a/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
+++ b/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
@@ -77,7 +77,7 @@ class EvictionTimer {
             executor = new ScheduledThreadPoolExecutor(1, new EvictorThreadFactory());
             executor.setRemoveOnCancelPolicy(true);
         }
-        ScheduledFuture<?> scheduledFuture =
+        final ScheduledFuture<?> scheduledFuture =
                 executor.scheduleWithFixedDelay(task, delay, period, TimeUnit.MILLISECONDS);
         task.setScheduledFuture(scheduledFuture);
     }

http://git-wip-us.apache.org/repos/asf/commons-pool/blob/7411f108/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java b/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
index bfda56c..fd8b912 100644
--- a/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
+++ b/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
@@ -32,7 +32,7 @@ public class NoOpCallStack implements CallStack {
     }
 
     @Override
-    public boolean printStackTrace(PrintWriter writer) {
+    public boolean printStackTrace(final PrintWriter writer) {
         return false;
     }
 

http://git-wip-us.apache.org/repos/asf/commons-pool/blob/7411f108/src/test/java/org/apache/commons/pool2/impl/NoOpCallStackTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/pool2/impl/NoOpCallStackTest.java b/src/test/java/org/apache/commons/pool2/impl/NoOpCallStackTest.java
index 83444cf..11ef301 100644
--- a/src/test/java/org/apache/commons/pool2/impl/NoOpCallStackTest.java
+++ b/src/test/java/org/apache/commons/pool2/impl/NoOpCallStackTest.java
@@ -25,9 +25,9 @@ import java.io.StringWriter;
 public class NoOpCallStackTest {
     @Test
     public void printStackTraceIsNoOp() throws Exception {
-        CallStack stack = NoOpCallStack.INSTANCE;
+        final CallStack stack = NoOpCallStack.INSTANCE;
         stack.fillInStackTrace();
-        StringWriter writer = new StringWriter();
+        final StringWriter writer = new StringWriter();
         stack.printStackTrace(new PrintWriter(writer));
         Assert.assertEquals("", writer.toString());
     }