You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/11/04 13:23:16 UTC

[GitHub] incubator-brooklyn pull request: delete/document binaries from sou...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/295

    delete/document binaries from source tree

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/delete-binaries-from-source

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #295
    
----
commit fa7373a8fc994a387d6108b1b0eb314929f4976c
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T10:21:29Z

    Delete unused cumulusrdf jar/war

commit cf2279cebaef1eeedb99a9c0d7b710a7cd238cde
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T10:22:45Z

    Fix CumulusRDFApplication
    
    - Start in just one location.
    - If try to start in two, then CassandraDatacenter complains
      (because of super DynamicClusterImpl.start)

commit d5c07bd4411c274bf14800019af273f35a29a145
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T10:23:30Z

    Remove qpid-test-plugin.jar binary
    
    - Download it instead
    - Note the test is disabled because was written for a really old qpid

commit 84ef0a35cbab7875398ed8c1b535c778228d3925
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T12:00:00Z

    Regenerate RebindCatalogEntityTest’s binary
    
    - Regenerate brooklyn-AppInCatalog.jar so that it includes
      its source.
    - Also adds .txt file to explain it

commit c02fabc4ed25e052af196d7afa5911ab2d0863a7
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T12:00:50Z

    Add .txt files to explain binary files

commit bacf622f9cc9ff12a9196c976323024fe685bcb1
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T12:03:33Z

    Regenerate OSGi bundle hello-world.jar to contain source

commit 22eda8dc1792ebeb23f0b7e6444c1d948e232ad2
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-04T12:17:35Z

    Fix DynamicWebAppClusterTest
    
    - Timeout of 1 second meant it was failing in apache jenkins
      sometimes, so remove the custom timeout and rely on the default.
    - Also tidies code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: delete/document binaries from sou...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: delete/document binaries from sou...

Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/295#issuecomment-61632528
  
    I don't particularly like the qpid-test-plugin.jar workaround of hosting it on developers.cloudsoftcorp.com, as at some point in the future it will cause link breakages. But since the test is disabled anyway due to it being out of date, I'm not going to object to this.
    
    Proceeding to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---