Re: [I] See if we need to handle deletes in unmerged reader [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #16693:
URL: https://github.com/apache/hudi/issues/16693#issuecomment-4795632353

   Triage: this looks resolved on master. The unmerged reader (`UnmergedFileGroupRecordBuffer`) now explicitly skips delete blocks — both `processDeleteBlock` and `processNextDeletedRecord` are no-ops, and `doHasNext` only emits records from `HoodieDataBlock` entries (`hudi-common/src/main/java/org/apache/hudi/common/table/read/buffer/UnmergedFileGroupRecordBuffer.java`). The decision was codified in commit `30f146500f9` ([HUDI-8411] / PR #12144 — 'Fix unmerged reader to skip delete blocks and avoid NPE'), which replaced earlier partial handling with the explicit invariant that no deletes flow through unmerged reads. If the only remaining concern is whether data log blocks can carry inline deletes (`_hoodie_is_deleted=true` rows), that's an orthogonal design question rather than a bug — please reopen with a concrete failure case if you'd like the team to revisit. Otherwise this can likely be closed as resolved by HUDI-8411.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org