You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/09/01 07:02:19 UTC

Re: Review Request 51548: LENS-1304 Log Driver query in lens finished_queries

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51548/#review147545
-----------------------------------------------------------




lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java (line 214)
<https://reviews.apache.org/r/51548/#comment214729>

    Need the reverse implementation too for the sake of completeness. The function `toQueryContext` should be able to take driver query from finished query and set inside query context. This will allow the driver query to be passed to the query details api too.


- Rajat Khandelwal


On Aug. 31, 2016, 5:20 p.m., Raghavendra Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51548/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2016, 5:20 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1304
>     https://issues.apache.org/jira/browse/LENS-1304
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Make driver query available in the finished_queries stats for deeper analytics
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 1d56757 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 47159b5 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 74d9a1f 
> 
> Diff: https://reviews.apache.org/r/51548/diff/
> 
> 
> Testing
> -------
> 
> Test added in TestLensDAO.java
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 12.621 s]
> [INFO] Lens ............................................... SUCCESS [ 14.930 s]
> [INFO] Lens API ........................................... SUCCESS [ 44.131 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 46.240 s]
> [INFO] Lens Cube .......................................... SUCCESS [21:11 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 32.606 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 28.387 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:47 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 56.947 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 33.325 s]
> [INFO] Lens Server ........................................ SUCCESS [22:44 min]
> [INFO] Lens client ........................................ SUCCESS [02:10 min]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 16.364 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  2.979 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 38.824 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:40 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 22.394 s]
> [INFO] Lens Regression .................................... SUCCESS [ 26.432 s]
> [INFO] Lens UI ............................................ SUCCESS [ 21.591 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:00 h
> [INFO] Finished at: 2016-08-30T19:25:13+05:30
> [INFO] Final Memory: 199M/1058M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Raghavendra Singh
> 
>