Re: [PR] [FLINK-39151][metrics] Hide warning about UnixOperatingSystemMXBean missing on Windows [flink]

["piotrp (via GitHub)" <gi...@apache.org>]

piotrp commented on code in PR #27662:
URL: https://github.com/apache/flink/pull/27662#discussion_r3052549487


##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java:
##########
@@ -351,7 +352,7 @@ static void instantiateFileDescriptorMetrics(MetricGroup metrics) {
                 metrics.<Long, Gauge<Long>>gauge("Max", unixMXBean::getMaxFileDescriptorCount);
                 metrics.<Long, Gauge<Long>>gauge("Open", unixMXBean::getOpenFileDescriptorCount);
 
-            } else {
+            } else if (!OperatingSystem.isWindows()) {

Review Comment:
   @Zakelly can you check whether it looks ok now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org