You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2012/11/10 01:31:24 UTC
Review Request: Set up a mechanism to support other keyboard types other
than English and Japanese.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7996/
-----------------------------------------------------------
Review request for cloudstack and Kelven Yang.
Description
-------
Refactoring the current keyboard support for console proxy. Pull out the key mapping tables
into a separate file so end users and other contributors can add to this table;
the more complex mapping rules stay in the original file.
Will add a document describing the usage in the wiki page. Link will be added in the bug.
This addresses bug CLOUDSTACK-62.
Diffs
-----
console-proxy/js/ajaxkeys.js PRE-CREATION
console-proxy/js/ajaxviewer.js 6ac56be
console-proxy/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java e4f4727
console-proxy/ui/viewer.ftl 0dd7b39
Diff: https://reviews.apache.org/r/7996/diff/
Testing
-------
Tested for Japanese keyboard with Xenserver 5.6, Windows OS, Firefox browser.
Thanks,
Fang Wang
Re: Review Request: Set up a mechanism to support other keyboard types other
than English and Japanese.
Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7996/#review13778
-----------------------------------------------------------
Ship it!
Ship It!
- Kelven Yang
On Nov. 10, 2012, 12:31 a.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7996/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2012, 12:31 a.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Description
> -------
>
> Refactoring the current keyboard support for console proxy. Pull out the key mapping tables
> into a separate file so end users and other contributors can add to this table;
> the more complex mapping rules stay in the original file.
>
> Will add a document describing the usage in the wiki page. Link will be added in the bug.
>
>
> This addresses bug CLOUDSTACK-62.
>
>
> Diffs
> -----
>
> console-proxy/js/ajaxkeys.js PRE-CREATION
> console-proxy/js/ajaxviewer.js 6ac56be
> console-proxy/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java e4f4727
> console-proxy/ui/viewer.ftl 0dd7b39
>
> Diff: https://reviews.apache.org/r/7996/diff/
>
>
> Testing
> -------
>
> Tested for Japanese keyboard with Xenserver 5.6, Windows OS, Firefox browser.
>
>
> Thanks,
>
> Fang Wang
>
>