You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2016/01/15 20:32:57 UTC

[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-8180 and CB-1...

GitHub user infil00p opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/135

    Fix for CB-8180 and CB-10104, ids are required for layout

    We need to review the URIs before the page loads, not after.  The custom URIs should work now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infil00p/cordova-plugin-inappbrowser custom_uri_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit 26a656422ee99fc2b77bcc6c8ff3d4a3b3463d44
Author: Joe Bowser <bo...@apache.org>
Date:   2016-01-15T19:30:11Z

    Fix for CB-8180 and CB-10104, ids are required for layout

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-8180 and CB-1...

Posted by infil00p <gi...@git.apache.org>.
Github user infil00p closed the pull request at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org