[GitHub] [beam] Abacn commented on a diff in pull request #26474: Cherry-pick: Add driverJars parameter to JdbcIO. (#25824)

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #26474:
URL: https://github.com/apache/beam/pull/26474#discussion_r1180743271


##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -67,6 +67,8 @@ public Schema configurationSchema() {
         .addNullableField("fetchSize", FieldType.INT16)
         .addNullableField("outputParallelization", FieldType.BOOLEAN)
         .addNullableField("autosharding", FieldType.BOOLEAN)
+        .addNullableField("maxConnections", FieldType.INT16)

Review Comment:
   This is a breaking change for xlang schema transform, see #25062
   
   in general we may need a better way to make this kind of change not breaking xlang



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org