You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2016/02/06 01:34:15 UTC
Review Request 43277: EU: Oozie service check failed after downgrade
with
multiple Oozie servers since rerunning prepare-war removes webapps/oozie
folder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
Bugs: AMBARI-14950
https://issues.apache.org/jira/browse/AMBARI-14950
Repository: ambari
Description
-------
STR:
1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
3. Perform Downgrade back to original version and let it complete
4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
Diffs
-----
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
Diff: https://reviews.apache.org/r/43277/diff/
Testing
-------
Verified on live cluster during EU + downgrade, and ran python unit tests.
Total run:886
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 43277: EU: Oozie service check failed after
downgrade
with multiple Oozie servers since rerunning prepare-war removes
webapps/oozie folder
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/#review118113
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py (line 244)
<https://reviews.apache.org/r/43277/#comment179347>
Notice that we now generate the marker file only if the prepare-war command was successful. Before, there would be conditions in which the marker file would be generated but the command was never ran.
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
<https://reviews.apache.org/r/43277/#comment179348>
Notice the not_if condition but a couple of lines below would still generate prepare_war_cmd_file marker file.
- Alejandro Fernandez
On Feb. 6, 2016, 12:34 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43277/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2016, 12:34 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14950
> https://issues.apache.org/jira/browse/AMBARI-14950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
>
> 1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
> 2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
> 3. Perform Downgrade back to original version and let it complete
> 4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
>
> There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
>
> Diff: https://reviews.apache.org/r/43277/diff/
>
>
> Testing
> -------
>
> Verified on live cluster during EU + downgrade, and ran python unit tests.
>
> Total run:886
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43277: EU: Oozie service check failed after
downgrade
with multiple Oozie servers since rerunning prepare-war removes
webapps/oozie folder
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Feb. 8, 2016, 3:15 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py, lines 211-212
> > <https://reviews.apache.org/r/43277/diff/1/?file=1236937#file1236937line211>
> >
> > Dangerous to assume /var/tmp/oozie even exists. mkdir -p /var/tmp/oozie ?
Good call.
> On Feb. 8, 2016, 3:15 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py, lines 238-239
> > <https://reviews.apache.org/r/43277/diff/1/?file=1236937#file1236937line238>
> >
> > Feels dangerous to rely on console output. Can check for file existence or something a bit more concrete here?
This is how it's working today, so I want to keep it that way.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/#review118235
-----------------------------------------------------------
On Feb. 6, 2016, 12:34 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43277/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2016, 12:34 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14950
> https://issues.apache.org/jira/browse/AMBARI-14950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
>
> 1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
> 2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
> 3. Perform Downgrade back to original version and let it complete
> 4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
>
> There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
>
> Diff: https://reviews.apache.org/r/43277/diff/
>
>
> Testing
> -------
>
> Verified on live cluster during EU + downgrade, and ran python unit tests.
>
> Total run:886
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43277: EU: Oozie service check failed after
downgrade
with multiple Oozie servers since rerunning prepare-war removes
webapps/oozie folder
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/#review118235
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py (lines 211 - 212)
<https://reviews.apache.org/r/43277/#comment179454>
Dangerous to assume /var/tmp/oozie even exists. mkdir -p /var/tmp/oozie ?
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py (lines 238 - 239)
<https://reviews.apache.org/r/43277/#comment179455>
Feels dangerous to rely on console output. Can check for file existence or something a bit more concrete here?
- Nate Cole
On Feb. 5, 2016, 7:34 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43277/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 7:34 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14950
> https://issues.apache.org/jira/browse/AMBARI-14950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
>
> 1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
> 2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
> 3. Perform Downgrade back to original version and let it complete
> 4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
>
> There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
>
> Diff: https://reviews.apache.org/r/43277/diff/
>
>
> Testing
> -------
>
> Verified on live cluster during EU + downgrade, and ran python unit tests.
>
> Total run:886
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43277: EU: Oozie service check failed after
downgrade
with multiple Oozie servers since rerunning prepare-war removes
webapps/oozie folder
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 7:57 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
Changes
-------
Addressed comments.
Bugs: AMBARI-14950
https://issues.apache.org/jira/browse/AMBARI-14950
Repository: ambari
Description
-------
STR:
1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
3. Perform Downgrade back to original version and let it complete
4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
Diff: https://reviews.apache.org/r/43277/diff/
Testing
-------
Verified on live cluster during EU + downgrade, and ran python unit tests.
Total run:886
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 43277: EU: Oozie service check failed after
downgrade
with multiple Oozie servers since rerunning prepare-war removes
webapps/oozie folder
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 8, 2016, 10:49 a.m., Jonathan Hurley wrote:
> > Ship It!
The above comments were the only ones I had. After addressing them, I don't see anything else to point out.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/#review118238
-----------------------------------------------------------
On Feb. 5, 2016, 7:34 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43277/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 7:34 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14950
> https://issues.apache.org/jira/browse/AMBARI-14950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
>
> 1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
> 2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
> 3. Perform Downgrade back to original version and let it complete
> 4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
>
> There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
>
> Diff: https://reviews.apache.org/r/43277/diff/
>
>
> Testing
> -------
>
> Verified on live cluster during EU + downgrade, and ran python unit tests.
>
> Total run:886
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43277: EU: Oozie service check failed after
downgrade
with multiple Oozie servers since rerunning prepare-war removes
webapps/oozie folder
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43277/#review118238
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 5, 2016, 7:34 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43277/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 7:34 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14950
> https://issues.apache.org/jira/browse/AMBARI-14950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
>
> 1. Setup HDP 2.3.4.0 cluster with Ambari 2.2.1 (secure, multiple oozie servers)
> 2, Start Express Upgrade to HDP-2.4.0.0-149 and reach till Finalize step
> 3. Perform Downgrade back to original version and let it complete
> 4. Run service check for Oozie, which fails because /usr/hdp/current/oozie-server/oozie-server/webapps/oozie is missing
>
> There's a bug that the /usr/hdp/current/oozie-server/.prepare_war_cmd marker file is still generated even if the prepare war command was not ran!
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 24a35ad
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py 35975df
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 326e76c
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2183425
>
> Diff: https://reviews.apache.org/r/43277/diff/
>
>
> Testing
> -------
>
> Verified on live cluster during EU + downgrade, and ran python unit tests.
>
> Total run:886
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>