You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/31 02:19:26 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #5382: Run sim:ostest on the CI
yamt opened a new pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805678172
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
But, I don't think there is any real benefit here. And how to extend with new test? e.g. if we add qemu for arm/xtensa later, how we organize the test list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805455482
##########
File path: tools/testbuild.sh
##########
@@ -276,6 +281,18 @@ function build {
return $fail
}
+function run {
+ if [ ${RUN} -ne 0 ]; then
+ run_script="$path/run"
Review comment:
nothing assumes it's a shell script.
but i can add .sh if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047396951
> > Yeah a fix is almost merged.
>
> ok. i will retry later today.
@yamt just re-queued CI for this PR issue with the build image is resolved and passing on master now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1032562916
@yamt @Ouss4 is it done? LGTM??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806410039
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
The name of sim-ostest.dat is too specific, which mean we can only put one test sim:ostest into this list, but the time to execute ostest is around 1 minute and much smaller than the average value.
I don't know how many test will be added later, but the time to execute the test is short in the current stage. Why not postpone the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047306284
> @yamt could you rebase to the latest?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1043831643
@yamt look like ostest generate a crash:(, we need fix it before enabling. The good point is that it demonstrate your patch can catch the real problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1043864572
> @yamt look like ostest generate a crash:(, we need fix it before enabling. The good point is that it demonstrate your patch can catch the real problem.
it seems like recursive pthread_exit calls.
```
frame #938: 0x000000010000f972 nuttx`pthread_exit(exit_value=0xffffffffffffffff) at pthread_exit.c:58:3
frame #939: 0x000000010000b506 nuttx`enter_cancellation_point at task_cancelpt.c:143:19
frame #940: 0x000000010000799e nuttx`sem_wait(sem=0x0000000101012074) at sem_wait.c:257:7
frame #941: 0x000000010001480f nuttx`lib_take_semaphore(stream=0x0000000101012068) at lib_libfilesem.c:80:21
frame #942: 0x00000001000142c0 nuttx`vfprintf(stream=0x0000000101012068, fmt="sem_cleaner #%u\n", ap=0x00000001010364c0) at lib_vfprintf.c:53:7
frame #943: 0x00000001000111ac nuttx`printf(fmt="sem_cleaner #%u\n") at lib_printf.c:44:9
frame #944: 0x000000010001db09 nuttx`sem_cleaner(arg=0x0000000000000003) at cancel.c:57:3
frame #945: 0x00000001000102d3 nuttx`pthread_cleanup_pop_tls(tls=0x0000000101024570, execute=1) at pthread_cleanup.c:86:11
frame #946: 0x00000001000103a9 nuttx`pthread_cleanup_popall(tls=0x0000000101024570) at pthread_cleanup.c:189:7
frame #947: 0x000000010000f972 nuttx`pthread_exit(exit_value=0xffffffffffffffff) at pthread_exit.c:58:3
frame #948: 0x000000010000b5b4 nuttx`leave_cancellation_point at task_cancelpt.c:230:19
frame #949: 0x00000001000054c5 nuttx`pthread_cond_wait(cond=0x0000000100039418, mutex=0x0000000100039408) at pthread_condwait.c:154:3
frame #950: 0x000000010001d6cc nuttx`sem_waiter(parameter=0x0000000000000001) at cancel.c:106:12
frame #951: 0x000000010000f94a nuttx`pthread_startup(entry=(nuttx`sem_waiter at cancel.c:62), arg=0x0000000000000001) at pthread_create.c:59:16
frame #952: 0x000000010000485c nuttx`pthread_start at pthread_create.c:188:3
(lldb)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r803949680
##########
File path: tools/testbuild.sh
##########
@@ -276,6 +281,18 @@ function build {
return $fail
}
+function run {
+ if [ ${RUN} -ne 0 ]; then
+ run_script="$path/run"
Review comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047365265
The test failure looks unrelated to this PR.
```
make[3]: rustc: Command not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r808509511
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
i haven't made the change yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047377813
> Yeah a fix is almost merged.
ok. i will retry later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047371469
Yeah a fix is almost merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047010587
@yamt could you rebase to the latest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1047400464
> > > Yeah a fix is almost merged.
> >
> >
> > ok. i will retry later today.
>
> @yamt just re-queued CI for this PR issue with the build image is resolved and passing on master now.
ok. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805455108
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
just because it's heavier than other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805455108
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
just because it's heavier than other tests.
##########
File path: tools/testbuild.sh
##########
@@ -276,6 +281,18 @@ function build {
return $fail
}
+function run {
+ if [ ${RUN} -ne 0 ]; then
+ run_script="$path/run"
Review comment:
nothing assumes it's a shell script.
but i can add .sh if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r808562614
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806330264
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
my assumption: these lists were organized to make each jobs to take similar time.
if we add tests, they should be organized according to how long they take.
maybe my assumption is wrong? please correct me in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1026341564
> > Do you plan to keep the test running on the build job?
>
> in the meantime, yes.
>
> > I believe it would work better to have separate test jobs that download the artifacts from the builds and then run the tests.
>
> do you mean to use a separate "step"? (in GHA term) while it might look nicer, i'm not sure if it's worth the extra complexity.
i think i misread your suggestion.
do you mean to use https://github.com/actions/download-artifact?
it makes sense.
are you suggesting to do it within this PR? or as a next step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1025492631
Do you plan to keep the test running on the build job?
I believe it would work better to have separate test jobs that download the artifacts from the builds and then run the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806330264
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
my assumption: these lists were organized to make each jobs to take similar time.
if we add tests, they should be organized according to how long they take.
maybe my assumption is wrong? please correct me in that case.
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
ok. i will drop the patch for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806410039
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
The name of sim-ostest.dat is too specific, which mean we can only put one test sim:ostest into this list, but the time to execute ostest is around 1 minute and much smaller than the average value.
I don't know how many test will be added later, but the time to execute the test is short in the current stage. Why not postpone the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1026098726
Nice idea @yamt !!! Next we need to find some way to run it on real hardware i.e.: esp32-devkitc, stm32f4discovery, same70-qmtech, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r808260289
##########
File path: tools/testbuild.sh
##########
@@ -276,6 +281,18 @@ function build {
return $fail
}
+function run {
+ if [ ${RUN} -ne 0 ]; then
+ run_script="$path/run"
Review comment:
I am fine with either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1043831643
@yamt look like ostest generate a crash:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1044049760
@yamt @xiaoxiang781216 Please see the fix #5543.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806410909
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
ok. i will drop the patch for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1026328334
> Do you plan to keep the test running on the build job?
in the meantime, yes.
> I believe it would work better to have separate test jobs that download the artifacts from the builds and then run the tests.
do you mean to use a separate "step"? (in GHA term)
while it might look nicer, i'm not sure if it's worth the extra complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1026337026
> Nice idea @yamt !!! Next we need to find some way to run it on real hardware i.e.: esp32-devkitc, stm32f4discovery, same70-qmtech, etc
i agree it would be great to have tests on real hardware.
i guess someone can prepare a self-hosted runner connected to those hardware via serial.
i don't have a plan to work on it by myself in foreseeable future though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1026627817
Yes I meant a new job not just a "step". Actually in our case the (long term) solution would be another test matrix where its jobs will download the artifacts uploaded from the build matrix jobs.
> are you suggesting to do it within this PR? or as a next step?
I think in order to make what I am proposing more useful we are going to need to setup QEMU for some of our chips or self-hosted runners with hardware. I know @btashton started working on something like this with QEMU.
Regarding self-hosted runners, I think these are setup at the organization level and we are going to need help from Apache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r808259559
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
But, I don't see the related change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1043942480
@no1wudi please take a look why the recursive happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1034507247
> @yamt @Ouss4 is it done? LGTM??
i agree with @Ouss4 about the long term solution.
i feel this version is good enough for now though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5382: Run sim:ostest on the CI
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r803473674
##########
File path: tools/ci/testlist/sim-02.dat
##########
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review comment:
why need to move the new test list?
##########
File path: tools/testbuild.sh
##########
@@ -276,6 +281,18 @@ function build {
return $fail
}
+function run {
+ if [ ${RUN} -ne 0 ]; then
+ run_script="$path/run"
Review comment:
should we add .sh suffix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org