You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by aseigneurin <gi...@git.apache.org> on 2017/03/27 16:16:59 UTC
[GitHub] spark pull request #17443: typos
GitHub user aseigneurin opened a pull request:
https://github.com/apache/spark/pull/17443
typos
Fixed a few typos.
There is one more I'm not sure of:
```
Append mode uses watermark to drop old aggregation state. But the output of a
windowed aggregation is delayed the late threshold specified in `withWatermark()` as by
the modes semantics, rows can be added to the Result Table only once after they are
```
Not sure how to change `is delayed the late threshold`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aseigneurin/spark typos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17443.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17443
----
commit 96a3ccc8f0f80d589c95995d0cf65e154188507e
Author: Seigneurin, Alexis (CONT) <al...@capitalone.com>
Date: 2017-03-27T16:09:48Z
typos
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17443: typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17443#discussion_r108230647
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -713,15 +713,15 @@ old windows correctly, as illustrated below.
-However, to run this query for days, it's necessary for the system to bound the amount of
+However, to run this query for days, it is necessary for the system to bound the amount of
--- End diff --
Not a typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17443: typos
Posted by aseigneurin <gi...@git.apache.org>.
Github user aseigneurin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17443#discussion_r108254245
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -930,7 +930,7 @@ There are a few types of output modes.
new rows added to the Result Table since the last trigger will be
outputted to the sink. This is supported for only those queries where
rows added to the Result Table is never going to change. Hence, this mode
-guarantees that each row will be output only once (assuming
+guarantees that each row will be outputted only once (assuming
--- End diff --
Interesting! I also thought "outputted" was strange.
I have reverted my change anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: [DOCS][MINOR] Fixed a few typos in the Structured Stream...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17443
**[Test build #3620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3620/testReport)** for PR 17443 at commit [`a2faf88`](https://github.com/apache/spark/commit/a2faf88e61c2b634dd81fdaea565234bc5d6012d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17443: [DOCS][MINOR] Fixed a few typos in the Structured...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17443
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: [DOCS][MINOR] Fixed a few typos in the Structured Stream...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17443
**[Test build #3620 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3620/testReport)** for PR 17443 at commit [`a2faf88`](https://github.com/apache/spark/commit/a2faf88e61c2b634dd81fdaea565234bc5d6012d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17443: typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17443#discussion_r108230830
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -930,7 +930,7 @@ There are a few types of output modes.
new rows added to the Result Table since the last trigger will be
outputted to the sink. This is supported for only those queries where
rows added to the Result Table is never going to change. Hence, this mode
-guarantees that each row will be output only once (assuming
+guarantees that each row will be outputted only once (assuming
--- End diff --
Not a typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17443: typos
Posted by aseigneurin <gi...@git.apache.org>.
Github user aseigneurin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17443#discussion_r108231410
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -930,7 +930,7 @@ There are a few types of output modes.
new rows added to the Result Table since the last trigger will be
outputted to the sink. This is supported for only those queries where
rows added to the Result Table is never going to change. Hence, this mode
-guarantees that each row will be output only once (assuming
+guarantees that each row will be outputted only once (assuming
--- End diff --
Not a typo, I agree, but I thought it made sense to keep the same formulation as what is used in the same paragraph
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: [DOCS][MINOR] Fixed a few typos in the Structured Stream...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17443
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17443: typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17443#discussion_r108231967
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -930,7 +930,7 @@ There are a few types of output modes.
new rows added to the Result Table since the last trigger will be
outputted to the sink. This is supported for only those queries where
rows added to the Result Table is never going to change. Hence, this mode
-guarantees that each row will be output only once (assuming
+guarantees that each row will be outputted only once (assuming
--- End diff --
Oh, hm. As a native speaker, I would have said "outputted" is incorrect actually. But it looks like it's an accepted alternative. Well, whatever's the smaller change to achieve consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17443
@tdas what did you intend in the paragraph cited in the description? I'm also not sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17443
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17443
@aseigneurin Please read http://spark.apache.org/contributing.html too. As you might imagine "typos" isn't useful as a title. Write "[MINOR]" too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17443: [DOCS][MINOR] Fixed a few typos in the Structured Stream...
Posted by aseigneurin <gi...@git.apache.org>.
Github user aseigneurin commented on the issue:
https://github.com/apache/spark/pull/17443
@srowen does this mean I should open a JIRA for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org