You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/27 22:18:59 UTC
[GitHub] [ozone] sodonnel opened a new pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
sodonnel opened a new pull request #3025:
URL: https://github.com/apache/ozone/pull/3025
## What changes were proposed in this pull request?
After creating a bucket using the shell:
ozone sh bucket create /vol1/testec -t EC -r rs-3-2-1024k
And then listing the bucket info, the EC Replication details are not reflected in the output:
```
{
"metadata" : { },
"volumeName" : "vol1",
"name" : "testec",
"storageType" : "DISK",
"versioning" : false,
"usedBytes" : 0,
"usedNamespace" : 0,
"creationTime" : "2022-01-27T17:29:54.289Z",
"modificationTime" : "2022-01-27T17:29:54.289Z",
"quotaInBytes" : -1,
"quotaInNamespace" : -1,
"bucketLayout" : "OBJECT_STORE",
"owner" : "hadoop",
"replicationConfig" : {
"replicationFactor" : "THREE",
"requiredNodes" : 3,
"replicationType" : "RATIS"
},
"link" : false
}
```
The issue is caused by a missing parameter into the new BucketObject from getBucketDetails vs ListBuckets. After this change the CLI works correctly:
```
bash-4.2$ ozone sh volume create /vol1
bash-4.2$ ozone sh bucket create -r rs-3-2-1024k -t EC /vol1/bucket1
bash-4.2$ ozone sh bucket list /vol1
[ {
"metadata" : { },
"volumeName" : "vol1",
"name" : "bucket1",
"storageType" : "DISK",
"versioning" : false,
"usedBytes" : 0,
"usedNamespace" : 0,
"creationTime" : "2022-01-27T22:09:21.194Z",
"modificationTime" : "2022-01-27T22:09:21.194Z",
"quotaInBytes" : -1,
"quotaInNamespace" : -1,
"bucketLayout" : "OBJECT_STORE",
"owner" : "hadoop",
"replicationConfig" : {
"data" : 3,
"parity" : 2,
"ecChunkSize" : 1048576,
"codec" : "RS",
"requiredNodes" : 5,
"replicationType" : "EC"
},
"link" : false
} ]
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6233
## How was this patch tested?
Manually via docker compose, but a acceptance test will be added via HDDS-6231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #3025:
URL: https://github.com/apache/ozone/pull/3025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #3025:
URL: https://github.com/apache/ozone/pull/3025#discussion_r794051780
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -842,7 +842,8 @@ public OzoneBucket getBucketDetails(
bucket.getQuotaInBytes(),
bucket.getQuotaInNamespace(),
bucket.getBucketLayout(),
- bucket.getOwner()))
+ bucket.getOwner(),
+ bucket.getDefaultReplicationConfig()))
Review comment:
Thanks for finding it. May be good idea to have simple test?
Otherwise I am +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #3025:
URL: https://github.com/apache/ozone/pull/3025#issuecomment-1023918564
@kaijchen, With the below patch put command should work to create EC Keys. Not sure you are talking about the same issue though.
https://issues.apache.org/jira/browse/HDDS-6184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao edited a comment on pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
Posted by GitBox <gi...@apache.org>.
umamaheswararao edited a comment on pull request #3025:
URL: https://github.com/apache/ozone/pull/3025#issuecomment-1023918564
@kaijchen, With the below patch put command should work to create EC Keys. Not sure you are talking about the same issue though. If your pointed issue is different, please file a JIRA with the details.
https://issues.apache.org/jira/browse/HDDS-6184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
Posted by GitBox <gi...@apache.org>.
kaijchen commented on pull request #3025:
URL: https://github.com/apache/ozone/pull/3025#issuecomment-1023922685
>
> @kaijchen, With the below patch put command should work to create EC Keys. Not sure you are talking about the same issue though. If your pointed issue is different, please file a JIRA with the details. https://issues.apache.org/jira/browse/HDDS-6184
Yes, that's exactly what I'm talking about. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #3025: HDDS-6233. EC: Bucket does not display correct EC replication details
Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #3025:
URL: https://github.com/apache/ozone/pull/3025#issuecomment-1024131682
I have added a test to an existing integration test suite. First I used the test to reproduce the issue and then confirmed it passed with the fix in place. Scarily, there are little to no unit level tests for the RpcClient. We seem to rely on integration type tests to check these things end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org