You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/12/13 20:14:44 UTC
[GitHub] [helix] jiajunwang commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
jiajunwang commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r768088199
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -622,7 +645,8 @@ void unregisterMessageHandlerFactory(String type) {
+ ", pool: " + pool);
if (pool != null) {
- shutdownAndAwaitTermination(pool);
+ int timeout = item == null? DEFAULT_MSG_HANDLER_RESET_TIMEOUT_MS : item.getResetTimeout();
+ shutdownAndAwaitTermination(pool, timeout);
Review comment:
Good point. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org