You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/03 21:35:08 UTC
Re: Review Request 54013: Added user doc for nested container and
task group.
> On Dec. 4, 2016, 11:44 a.m., Vinod Kone wrote:
> > docs/nested-container-and-task-group.md, line 209
> > <https://reviews.apache.org/r/54013/diff/3/?file=1573149#file1573149line209>
> >
> > mention that only 2 levels of nesting is supported as of 1.1?
>
> Gilbert Song wrote:
> We already support arbitrary nested levels. There is a unit test (`ROOT_CGROUPS_LaunchNestedThreeLevels`) for that support.
>
> Adam B wrote:
> And yet https://github.com/apache/mesos/blob/1.1.0/src/slave/http.cpp#L1929 says
> "We do not yet support launching containers that are nested two levels beneath the executor's container."
> and errors if you try to launch a nested container with a grandparent.
Fixed on a followup patch.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157928
-----------------------------------------------------------
On Dec. 6, 2016, 8:28 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 8:28 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added user doc for nested container and task group.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54013/diff/
>
>
> Testing
> -------
>
> Tested by gist view. Here is the link:
>
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
>
>
> Thanks,
>
> Gilbert Song
>
>