You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Dang Nguyen <ha...@comcast.net> on 2008/07/02 17:14:25 UTC
any reason to restrict commit log length?
I have a user that just committed a file and pasted an entire email thread
(plain text) into the commit log. His log entry is roughly 2600 characters
long. Before I go pound this user and restrict the length with a pre-commit
hook, I was curious if there was any good reason to restrict the length of
the commit log (other than this user constantly annoys me)?
We're running Subversion 1.5.0 (CollabNet binaries) and Apache 2.2 on
Windows Server 2003 if that makes any difference.
Thanks,
Dang Nguyen
RE: any reason to restrict commit log length?
Posted by Dang Nguyen <ha...@comcast.net>.
> -----Original Message-----
> From: Matthieu Moy [mailto:Matthieu.Moy@imag.fr]
> Sent: Wednesday, July 02, 2008 10:25 AM
> To: Dang Nguyen
> Cc: users@subversion.tigris.org
> Subject: Re: any reason to restrict commit log length?
>
> "Dang Nguyen" <ha...@comcast.net> writes:
>
> > I have a user that just committed a file and pasted an entire email
> thread
> > (plain text) into the commit log. His log entry is roughly 2600
> characters
> > long.
>
> The question is not how long the message is, but how long does it need
> to be to explain the content of the commit.
>
> 2600 characters is long, but I don't know whether it is _too_ long ...
>
> --
> Matthieu
In this case, the email thread is interaction between him and a customer;
thus, it's too long. It really could be summarized for the rest of the
developers.
Dang
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: any reason to restrict commit log length?
Posted by Andy Levy <an...@gmail.com>.
On Wed, Jul 2, 2008 at 13:24, Matthieu Moy <Ma...@imag.fr> wrote:
> "Dang Nguyen" <ha...@comcast.net> writes:
>
>> I have a user that just committed a file and pasted an entire email thread
>> (plain text) into the commit log. His log entry is roughly 2600 characters
>> long.
>
> The question is not how long the message is, but how long does it need
> to be to explain the content of the commit.
>
> 2600 characters is long, but I don't know whether it is _too_ long ...
I recently wrote a commit message that was 1713 characters; 2600
doesn't seem too huge, but it completely depends upon the nature of
the change you're committing and how verbose you are.
Copying & pasting an entire email thread verbatim sounds like a user
behavior adjustment is required.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: any reason to restrict commit log length?
Posted by Matthieu Moy <Ma...@imag.fr>.
"Dang Nguyen" <ha...@comcast.net> writes:
> I have a user that just committed a file and pasted an entire email thread
> (plain text) into the commit log. His log entry is roughly 2600 characters
> long.
The question is not how long the message is, but how long does it need
to be to explain the content of the commit.
2600 characters is long, but I don't know whether it is _too_ long ...
--
Matthieu
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
RE: any reason to restrict commit log length?
Posted by Dang Nguyen <ha...@comcast.net>.
> -----Original Message-----
> From: Reedick, Andrew [mailto:jr9445@ATT.COM]
> Sent: Wednesday, July 02, 2008 10:49 AM
> To: Dang Nguyen; users@subversion.tigris.org
> Subject: RE: any reason to restrict commit log length?
>
>
>
> > From: Dang Nguyen [mailto:haidangwa@comcast.net]
> > Sent: Wednesday, July 02, 2008 1:14 PM
> > To: users@subversion.tigris.org
> > Subject: any reason to restrict commit log length?
> >
> > I have a user that just committed a file and pasted
> > an entire email thread (plain text) into the commit
> > log. His log entry is roughly 2600 characters long.
> > Before I go pound this user and restrict the length
> > with a pre-commit hook, I was curious if there was
> > any good reason to restrict the length of the commit
> > log (other than this user constantly annoys me)?
>
>
> Short answer: No good reason.
> Long answer: create a pre-commit hook that reads from a "favorite users
> list" and invokes a sleep command with a sleep time that's proportional
> to the commit message length.
>
>
>
>
I like this answer!
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
RE: any reason to restrict commit log length?
Posted by "Reedick, Andrew" <jr...@ATT.COM>.
> From: Dang Nguyen [mailto:haidangwa@comcast.net]
> Sent: Wednesday, July 02, 2008 1:14 PM
> To: users@subversion.tigris.org
> Subject: any reason to restrict commit log length?
>
> I have a user that just committed a file and pasted
> an entire email thread (plain text) into the commit
> log. His log entry is roughly 2600 characters long.
> Before I go pound this user and restrict the length
> with a pre-commit hook, I was curious if there was
> any good reason to restrict the length of the commit
> log (other than this user constantly annoys me)?
Short answer: No good reason.
Long answer: create a pre-commit hook that reads from a "favorite users list" and invokes a sleep command with a sleep time that's proportional to the commit message length.
*****
The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential, proprietary, and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from all computers. GA625
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: any reason to restrict commit log length?
Posted by Karl Fogel <kf...@red-bean.com>.
Lorenz <lo...@yahoo.com> writes:
> Dang Nguyen wrote:
>>[...] if there was any good reason to restrict the length of
>>the commit log
>
> I don't know if you are aiming for technical reasons ...
>
> but out of curiosity I just googled around a bit and found:
>
> http://subversion.tigris.org/design.html
>
> ... A property value is an arbitrary string of bytes.
> Property values may be of any size, but Subversion
> may not handle very large property values efficiently.
That's more about versioned properties (the ones attached to versioned
files and directories), and not so much about unversioned properties
(the ones attached to revision numbers). Though I suppose a revision
property that was tens of megabytes or larger might be a problem; I
don't know -- I'm just guessing, would be interested if you have
experience with that.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: any reason to restrict commit log length?
Posted by Dang Nguyen <ha...@comcast.net>.
Lorenz wrote:
> Dang Nguyen wrote:
>
>> [...] if there was any good reason to restrict the length of
>> the commit log
>>
>
> I don't know if you are aiming for technical reasons ...
>
> but out of curiosity I just googled around a bit and found:
>
> http://subversion.tigris.org/design.html
>
> ... A property value is an arbitrary string of bytes.
> Property values may be of any size, but Subversion
> may not handle very large property values efficiently.
>
Well, sort of. I was more curious if a bunch of large commit logs might
eventually cause system degradation or some other "wackiness".
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: any reason to restrict commit log length?
Posted by Lorenz <lo...@yahoo.com>.
Dang Nguyen wrote:
>[...] if there was any good reason to restrict the length of
>the commit log
I don't know if you are aiming for technical reasons ...
but out of curiosity I just googled around a bit and found:
http://subversion.tigris.org/design.html
... A property value is an arbitrary string of bytes.
Property values may be of any size, but Subversion
may not handle very large property values efficiently.
--
Lorenz
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: any reason to restrict commit log length?
Posted by Blair Zajac <bl...@orcaware.com>.
Dang Nguyen wrote:
> I have a user that just committed a file and pasted an entire email
> thread (plain text) into the commit log. His log entry is roughly 2600
> characters long. Before I go pound this user and restrict the length
> with a pre-commit hook, I was curious if there was any good reason to
> restrict the length of the commit log (other than this user constantly
> annoys me)?
Not really. But if there's that much information, it should belong in the code
itself, not the revision log message, since people won't see that message if
they are looking through code.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org