You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/29 18:43:37 UTC
[GitHub] [tvm] junrushao1994 opened a new pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
junrushao1994 opened a new pull request #9150:
URL: https://github.com/apache/tvm/pull/9150
In unittests, we establish a "faked" RPC tracker/runner locally, but we forgot to wait until the server process is set up, which causes flakiness on mainline.
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/1815/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930448462
@shingjan Yes it's far more than enough as I experimented with @zxybazh weeks ago, but I did some refactoring when upstreaming the codebase, which accidentally dropped this line...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930449470
LGTM. Thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930498047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930521035
@tqchen right, the server needs some time to talk to the tracker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9150:
URL: https://github.com/apache/tvm/pull/9150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-933721902
it would be great for these fixes if, in the future, they could come with a comment explaining why we're adding sleep :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930499057
OK, answering my own Q, this might be needed for server to connect to tracker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930449470
LGTM. Thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930498047
Interesting, under popen impl, we should have wait until we get the related fields(where socket already binds) https://github.com/apache/tvm/blob/main/python/tvm/rpc/tracker.py#L450
Same thing for server, so i wonder why wait is still needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9150: [Hotfix][Testing] Wait for RPCServer to be established
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9150:
URL: https://github.com/apache/tvm/pull/9150#issuecomment-930448462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org