You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/01/06 14:49:00 UTC
[jira] [Commented] (HBASE-21661) Provide Thrift2 implementation of Table/Admin

    [ https://issues.apache.org/jira/browse/HBASE-21661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735204#comment-16735204 ] 

Hadoop QA commented on HBASE-21661:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 12s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  3m 53s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 43s{color} | {color:red} hbase-thrift generated 8 new + 11 unchanged - 7 fixed = 19 total (was 18) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 27s{color} | {color:red} hbase-thrift: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m  7s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  2m 13s{color} | {color:red} The patch causes 13 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 26s{color} | {color:red} The patch causes 13 errors with Hadoop v3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 23s{color} | {color:red} hbase-thrift generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 29s{color} | {color:red} hbase-thrift in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 10s{color} | {color:red} The patch generated 4 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m  7s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-thrift |
|  |  The method name org.apache.hadoop.hbase.thrift2.ThriftUtilities.IncrementFromHBase(Increment) doesn't start with a lower case letter  At ThriftUtilities.java:start with a lower case letter  At ThriftUtilities.java:[lines 1388-1419] |
|  |  Possible doublecheck on org.apache.hadoop.hbase.thrift2.client.ThriftConnection.httpClient in org.apache.hadoop.hbase.thrift2.client.ThriftConnection.getHttpClient()  At ThriftConnection.java:org.apache.hadoop.hbase.thrift2.client.ThriftConnection.getHttpClient()  At ThriftConnection.java:[lines 197-201] |
|  |  Inconsistent synchronization of org.apache.hadoop.hbase.thrift2.client.ThriftConnection.httpClient; locked 50% of time  Unsynchronized access at ThriftConnection.java:50% of time  Unsynchronized access at ThriftConnection.java:[line 86] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21661 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12953895/HBASE-21661.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 40d9dc9a460d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / 94093e869a |
| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/patch-mvninstall-root.txt |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/diff-compile-javac-hbase-thrift.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt |
| hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/patch-javac-2.7.4.txt |
| hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/patch-javac-3.0.0.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/new-findbugs-hbase-thrift.html |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/patch-unit-hbase-thrift.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/artifact/patchprocess/patch-asflicense-problems.txt |
| Max. process+thread count | 97 (vs. ulimit of 10000) |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15467/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Provide Thrift2 implementation of Table/Admin
> ---------------------------------------------
>
>                 Key: HBASE-21661
>                 URL: https://issues.apache.org/jira/browse/HBASE-21661
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-21661.patch
>
>
> Provide Thrift2 implementation of Table/Admin, making Java user to use thrift client more easily(Some environment which can not expose ZK or RS Servers directly require thrift or REST protocol even using Java). 
> Another Example of this is RemoteHTable and RemoteAdmin, they are REST connectors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)