[GitHub] [spark] MaxGekk commented on a diff in pull request #39402: [SPARK-41889][SQL] Attach root cause to invalidPatternError

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #39402:
URL: https://github.com/apache/spark/pull/39402#discussion_r1062212802


##########
sql/core/src/test/resources/sql-tests/results/postgreSQL/text.sql.out:
##########
@@ -312,7 +312,7 @@ org.apache.spark.sql.AnalysisException
   "errorClass" : "INVALID_PARAMETER_VALUE",
   "sqlState" : "22023",
   "messageParameters" : {
-    "expected" : "expects %1$, %2$ and so on, but got %0$.",
+    "value" : "expects %1$, %2$ and so on, but got %0$.",

Review Comment:
   This is why it is named `expected` - the parameter tells what Spark expects. cc @srielau 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org