You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "fgerlits (via GitHub)" <gi...@apache.org> on 2023/05/03 10:02:31 UTC

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1567: MINIFICPP-2111 - Remove test-only method

fgerlits commented on code in PR #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567#discussion_r1183483569


##########
extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:
##########
@@ -456,7 +452,7 @@ Remote Process Groups:
 NiFi Properties Overrides: {}
       )";
   std::istringstream configYamlStream(TEST_CONFIG_YAML);

Review Comment:
   this `configYamlStream` (and the one at line 497) are no longer needed, either



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org