You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/10 10:44:35 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: no
default build phase for dep-check
DaanHoogland opened a new pull request #3956: no default build phase for dep-check
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker update.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-603283829
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland opened a new pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez removed a comment on issue #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598819004
@DaanHoogland I'm hitting this error when building:
````
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:28 min (Wall Clock)
[INFO] Finished at: 2020-03-13T13:47:08-03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.14.0.0-SNAPSHOT: Failure to find com.sun.xml.ws:jaxws-ri:pom:2.6 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :cloud-vmware-base
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-599391483
very frustrating, I'm hitting a different one:
```
[ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.14.0.0-SNAPSHOT: Failure to find com.sun.xml.ws:jaxws-ri:pom:2.6 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-603268868
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598724323
@rhtyd @weizhouapache @GabrielBrascher finally apache builds gave a positive again on this maven update. can you approve?
cc @svenvogel @PaulAngus @anybody
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3956: maven quality tool
plugins
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-603268594
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3956: maven quality tool
plugins
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598867345
@DaanHoogland I got this error when building (with update dependecies flag)
````
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:24 min
[INFO] Finished at: 2020-03-13T14:11:21-03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could not resolve dependencies for project org.apache.cloudstack:cloud-plugin-network-f5:jar:4.14.0.0-SNAPSHOT: Could not find artifact commons-discovery:commons-discovery:jar:1.0-dev in central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :cloud-plugin-network-f5
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3956: maven quality tool
plugins
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598819004
@DaanHoogland I'm hitting this error when building:
````
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:28 min (Wall Clock)
[INFO] Finished at: 2020-03-13T13:47:08-03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.14.0.0-SNAPSHOT: Failure to find com.sun.xml.ws:jaxws-ri:pom:2.6 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :cloud-vmware-base
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland opened a new pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.
Some version discrepencies arose so version upgrades are included and `mvn dependency:tree | grep <this or that> | sort -u` gave some that need handling:
```
com.fasterxml.jackson.core:jackson-core:jar:2.1.3:compile
com.fasterxml.jackson.core:jackson-core:jar:2.9.10:compile
com.google.code.findbugs:jsr305:jar:1.3.9:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
com.google.http-client:google-http-client:jar:1.17.0-rc:compile
com.google.http-client:google-http-client:jar:1.20.0:compile
com.unboundid:unboundid-ldapsdk:jar:3.2.0:compile
com.unboundid:unboundid-ldapsdk:jar:4.0.14:test
commons-collections:commons-collections:jar:3.2.1:compile
commons-collections:commons-collections:jar:3.2.2:compile
commons-logging:commons-logging:jar:1.1.1:compile
commons-logging:commons-logging:jar:1.2:compile
javax.annotation:javax.annotation-api:jar:1.3.2:compile
# javax.annotation:javax.annotation-api:jar:1.3:compile
joda-time:joda-time:jar:2.10.5:compile
# joda-time:joda-time:jar:2.2:compile
# joda-time:joda-time:jar:2.8.1:compile
# joda-time:joda-time:jar:2.9.3:compile
org.slf4j:slf4j-api:jar:1.7.29:compile
org.slf4j:slf4j-log4j12:jar:1.7.29:compile
xerces:xercesImpl:jar:2.12.0:test
# xerces:xercesImpl:jar:2.8.0:compile
xml-apis:xml-apis-ext:jar:1.3.04:compile
# xml-apis:xml-apis:jar:1.0.b2:compile,test
# xml-apis:xml-apis:jar:1.4.01:test
xml-apis:xml-apis:jar:2.0.2:test,compile ???
```
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-604050076
<b>Trillian test result (tid-1302)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3956-t1302-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 0.34 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-599510525
`mvn clean install -Dnoredist -P developer,systemvm -U` tried, it doesn't complete with above error. Unfortunately having a compiled system is more important than having good analysis output so no go for this, for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-599109754
@nvazquez I had been using -Dnonoss which has not been in use for ever and a day. You are right the dependency on f5 doesn't work.
testing further with `mvn clean install -Dnoredist -P developer,systemvm`, but it needs to work with `mvn site -Dnoredist` as well, will push if i get both to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598814046
ping @weizhouapache @kiwiflyer @GabrielBrascher @rhtyd @nathanejohnson @andrijapanic-dont-use-this-one @svenvogel @wido this is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3956: maven quality tool
plugins
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-599489135
@DaanHoogland can you try adding `-U` to force updating the dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland opened a new pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.
Some version discrepencies arose so version upgrades are included and `mvn dependency:tree | grep <this or that> | sort -u` gave some that need handling:
```
com.fasterxml.jackson.core:jackson-core:jar:2.1.3:compile
com.fasterxml.jackson.core:jackson-core:jar:2.9.10:compile
com.google.code.findbugs:jsr305:jar:1.3.9:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
com.google.http-client:google-http-client:jar:1.17.0-rc:compile
com.google.http-client:google-http-client:jar:1.20.0:compile
com.unboundid:unboundid-ldapsdk:jar:3.2.0:compile
com.unboundid:unboundid-ldapsdk:jar:4.0.14:test
commons-collections:commons-collections:jar:3.2.1:compile
commons-collections:commons-collections:jar:3.2.2:compile
commons-logging:commons-logging:jar:1.1.1:compile
commons-logging:commons-logging:jar:1.2:compile
javax.annotation:javax.annotation-api:jar:1.3.2:compile
# javax.annotation:javax.annotation-api:jar:1.3:compile
joda-time:joda-time:jar:2.10.5:compile
# joda-time:joda-time:jar:2.2:compile
# joda-time:joda-time:jar:2.8.1:compile
# joda-time:joda-time:jar:2.9.3:compile
org.slf4j:slf4j-api:jar:1.7.29:compile
org.slf4j:slf4j-log4j12:jar:1.7.29:compile
xerces:xercesImpl:jar:2.12.0:test
# xerces:xercesImpl:jar:2.8.0:compile
xml-apis:xml-apis-ext:jar:1.3.04:compile
# xml-apis:xml-apis:jar:1.0.b2:compile,test
# xml-apis:xml-apis:jar:1.4.01:test
xml-apis:xml-apis:jar:2.0.2:test,compile ???
```
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-603150236
ok, builds now on
- fedora 31 and
- @nvazquez' ubuntu (what's the version) and
- macos 10.15.3 (19D76) provided the sed hack is added (see #3312 )
- jenkins job
@rhtyd @weizhouapache @GabrielBrascher can you approve?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland opened a new pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.
Some version discrepencies arose so version upgrades are included and `mvn dependency:tree | grep <this or that> | sort -u` gave some that need handling:
```
com.fasterxml.jackson.core:jackson-core:jar:2.1.3:compile
com.fasterxml.jackson.core:jackson-core:jar:2.9.10:compile
com.google.code.findbugs:jsr305:jar:1.3.9:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
com.google.http-client:google-http-client:jar:1.17.0-rc:compile
com.google.http-client:google-http-client:jar:1.20.0:compile
com.unboundid:unboundid-ldapsdk:jar:3.2.0:compile
com.unboundid:unboundid-ldapsdk:jar:4.0.14:test
commons-collections:commons-collections:jar:3.2.1:compile
commons-collections:commons-collections:jar:3.2.2:compile
commons-logging:commons-logging:jar:1.1.1:compile
commons-logging:commons-logging:jar:1.2:compile
javax.annotation:javax.annotation-api:jar:1.3.2:compile
# javax.annotation:javax.annotation-api:jar:1.3:compile
joda-time:joda-time:jar:2.10.5:compile
# joda-time:joda-time:jar:2.2:compile
# joda-time:joda-time:jar:2.8.1:compile
# joda-time:joda-time:jar:2.9.3:compile
org.slf4j:slf4j-api:jar:1.7.29:compile
org.slf4j:slf4j-log4j12:jar:1.7.29:compile
xerces:xercesImpl:jar:2.12.0:test
# xerces:xercesImpl:jar:2.8.0:compile
xml-apis:xml-apis-ext:jar:1.3.04:compile
# xml-apis:xml-apis:jar:1.0.b2:compile,test
# xml-apis:xml-apis:jar:1.4.01:test
xml-apis:xml-apis:jar:2.0.2:test,compile ???
```
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland opened a new pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven
quality tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland opened a new pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
## Description
<!--- Describe your changes in detail -->
owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.
Some version discrepencies arose so version upgrades are included and `mvn dependency:tree | grep <this or that> | sort -u` gave some that need handling:
```
com.fasterxml.jackson.core:jackson-core:jar:2.1.3:compile
com.fasterxml.jackson.core:jackson-core:jar:2.9.10:compile
com.google.code.findbugs:jsr305:jar:1.3.9:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
com.google.http-client:google-http-client:jar:1.17.0-rc:compile
com.google.http-client:google-http-client:jar:1.20.0:compile
com.unboundid:unboundid-ldapsdk:jar:3.2.0:compile
com.unboundid:unboundid-ldapsdk:jar:4.0.14:test
commons-collections:commons-collections:jar:3.2.1:compile
commons-collections:commons-collections:jar:3.2.2:compile
commons-logging:commons-logging:jar:1.1.1:compile
commons-logging:commons-logging:jar:1.2:compile
javax.annotation:javax.annotation-api:jar:1.3.2:compile
# javax.annotation:javax.annotation-api:jar:1.3:compile
joda-time:joda-time:jar:2.10.5:compile
# joda-time:joda-time:jar:2.2:compile
# joda-time:joda-time:jar:2.8.1:compile
# joda-time:joda-time:jar:2.9.3:compile
org.slf4j:slf4j-api:jar:1.7.29:compile
org.slf4j:slf4j-log4j12:jar:1.7.29:compile
xerces:xercesImpl:jar:2.12.0:test
# xerces:xercesImpl:jar:2.8.0:compile
xml-apis:xml-apis-ext:jar:1.3.04:compile
# xml-apis:xml-apis:jar:1.0.b2:compile,test
# xml-apis:xml-apis:jar:1.4.01:test
xml-apis:xml-apis:jar:2.0.2:test,compile ???
```
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3956: maven quality tool
plugins
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-599150968
@DaanHoogland I checked that the version 1.0-dev for the dependency commons-discovery is not present in the artifactory, so I changed the version to 0.5 (he last available in the repo: https://mvnrepository.com/artifact/commons-discovery/commons-discovery/0.5).
After changing that, I'm hitting a different error:
````
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:42 min
[INFO] Finished at: 2020-03-14T20:48:46-03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project cloud-plugin-outofbandmanagement-driver-nested-cloudstack: Could not resolve dependencies for project org.apache.cloudstack:cloud-plugin-outofbandmanagement-driver-nested-cloudstack:jar:4.14.0.0-SNAPSHOT: Failed to collect dependencies at org.apache.cloudstack:cloud-server:jar:clover:4.14.0.0-SNAPSHOT -> org.apache.cloudstack:cloud-framework-jobs:jar:4.14.0.0-SNAPSHOT -> org.apache.cloudstack:cloud-framework-events:jar:4.14.0.0-SNAPSHOT -> com.google.guava:guava:jar:28.2-jre -> org.checkerframework:checker-qual:jar:2.10.0: class java.util.HashMap$Node cannot be cast to class java.util.HashMap$TreeNode (java.util.HashMap$Node and java.util.HashMap$TreeNode are in module java.base of loader 'bootstrap') -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :cloud-plugin-outofbandmanagement-driver-nested-cloudstack
````
BTW: I'm compiling with:
````
mvn clean install -Dnoredist -P developer,systemvm -DskipTests -U
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality
tool plugins
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-602487377
@svenvogel why would you put a label security on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services