You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2015/10/07 08:37:30 UTC
Review Request 39074: [Hive View] UI issue with Hive View in old
Firefox browser
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39074/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13330
https://issues.apache.org/jira/browse/AMBARI-13330
Repository: ambari
Description
-------
Created new css clss to set the box-size CSS property and applied the same class wherever it was failing in old fire fox version.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/components/typeahead-widget.js b38c891
contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 5283daf
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/navbar-widget.hbs f8f6bcb
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases.hbs 068478b
Diff: https://reviews.apache.org/r/39074/diff/
Testing
-------
Manually tested the CSS changes and did a regression on other browsers as well e.g. Chrome and Safari to make sure this change is not breaking in any other browser.
Thanks,
Pallav Kulshreshtha
Re: Review Request 39074: [Hive View] UI issue with Hive View in old
Firefox browser
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39074/#review102477
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Oct. 7, 2015, 6:37 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39074/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 6:37 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13330
> https://issues.apache.org/jira/browse/AMBARI-13330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created new css clss to set the box-size CSS property and applied the same class wherever it was failing in old fire fox version.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/typeahead-widget.js b38c891
> contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 5283daf
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/navbar-widget.hbs f8f6bcb
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases.hbs 068478b
>
> Diff: https://reviews.apache.org/r/39074/diff/
>
>
> Testing
> -------
>
> Manually tested the CSS changes and did a regression on other browsers as well e.g. Chrome and Safari to make sure this change is not breaking in any other browser.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>