[GitHub] [hudi] wangxianghu removed a comment on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

[GitBox <gi...@apache.org>]

wangxianghu removed a comment on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-702217863


   > @leesf do you see the following exception? could not understand how you ll get the other one even.
   > 
   > ```
   > LOG.info("Starting Timeline service !!");
   >         Option<String> hostAddr = context.getProperty(EngineProperty.EMBEDDED_SERVER_HOST);
   >         if (!hostAddr.isPresent()) {
   >           throw new HoodieException("Unable to find host address to bind timeline server to.");
   >         }
   >         timelineServer = Option.of(new EmbeddedTimelineService(context, hostAddr.get(),
   >             config.getClientSpecifiedViewStorageConfig()));
   > ```
   > 
   > Either way, good pointer. the behavior has changed around this a bit actually. So will try and tweak and push a fix
   
   I got this warning too. The code here seems not the same.
   ```
    // Run Embedded Timeline Server
           LOG.info("Starting Timeline service !!");
           Option<String> hostAddr = context.getProperty(EngineProperty.EMBEDDED_SERVER_HOST);
           timelineServer = Option.of(new EmbeddedTimelineService(context, hostAddr.orElse(null),
               config.getClientSpecifiedViewStorageConfig()));
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org