You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/03 20:38:20 UTC
[GitHub] [incubator-superset] trebor opened a new pull request #7441: Add
sankey loop
trebor opened a new pull request #7441: Add sankey loop
URL: https://github.com/apache/incubator-superset/pull/7441
### CATEGORY
- Enhancement (new features, refinement)
### SUMMARY
Add a new [sankey chart](https://github.com/ricklupton/d3-sankey-diagram) which permits loops. Note that the this does NOT include the looped sankey data, the way we had plugged that in was not fit for review. :)
the modified energy data with loops [here in a gist](https://gist.github.com/trebor/af58adec502deaebb9af3f16de6fedb0), but better data should created.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
Look at the chart and see if it don't suck.
### REVIEWERS
@xtinec @williaster
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org