You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/02 02:53:19 UTC
[GitHub] [pulsar] hangc0276 opened a new pull request #6856: fix add partition failed when bundle unloaded
hangc0276 opened a new pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856
### Motivation
When a topic with high input/output load, we will get add partition failed, the failed log as follows:
```
Failed to perform http post request: org.asynchttpclient.handler.MaxRedirectException: Maximum redirect reached: 5
null
Reason: org.asynchttpclient.handler.MaxRedirectException: Maximum redirect reached: 5
```
### Bug description
The reason is when the topic with high load, the topic's bundle will be unload. In the same time, we call pulsar admin to add partition for the topic, the request will post to one broker A, broker A can't find the topic-bundle's owner, it will redirect the request to the leader broker B, broker B find a candidate broker C to own the bundle, and redirect request to broker C with authoritative flag.
However, broker C can't receive the authoritative flag (that's the bug), and can't find the topic-bundle's owner and has no authoritative flag, so it redirect the request to the leader broker B and goes on in cycle. In the end it reaches the max redirect limit and failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6856: fix add partition failed when bundle unloaded
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856#issuecomment-623071920
> Maybe not, the broker should own the topic-bundle before update partitions.
This is also where I doubt. Update partitions we just need to update the partitioned topic metadata in Zookeeper, to own a namespace bundle happens when the client sends a lookup request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6856: fix add partition failed when bundle unloaded
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856#issuecomment-633605137
ping @sijie @jiazhai Please help review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #6856: fix add partition failed when bundle unloaded
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #6856: fix add partition failed when bundle unloaded
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856#issuecomment-633973470
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #6856: fix add partition failed when bundle unloaded
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856#issuecomment-622666376
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #6856: fix add partition failed when bundle unloaded
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #6856:
URL: https://github.com/apache/pulsar/pull/6856#issuecomment-623054781
> @hangc0276 Is it possible to remove the ownership check for update partitions? I'm not sure why to update partitions need to check topic ownership.
Maybe not, the broker should own the topic-bundle before update partitions. When the topic-bundle unloaded, the broker should ask the leader to find candidate broker and authoritative the candidate broker to own the topic-bundle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org