You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Masahiro Tanaka <ta...@oss.nttdata.com> on 2017/04/20 14:59:05 UTC
Review Request 58575: Ambari Metrics Storm Sink compilation error due
to storm-1.1.0-SNAPSHOT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-20797
https://issues.apache.org/jira/browse/AMBARI-20797
Repository: ambari
Description
-------
I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT
Diffs
-----
ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63
Diff: https://reviews.apache.org/r/58575/diff/1/
Testing
-------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.
Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error
due to storm-1.1.0-SNAPSHOT
Posted by Masahiro Tanaka <ta...@oss.nttdata.com>.
> On April 29, 2017, 3:35 a.m., Aravindan Vijayan wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you! Could you commit it?
>
> Aravindan Vijayan wrote:
> Done. Please close the review and the jira.
Thank you very much!
- Masahiro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
-----------------------------------------------------------
On April 20, 2017, 11:59 p.m., Masahiro Tanaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 11:59 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63
>
>
> Diff: https://reviews.apache.org/r/58575/diff/1/
>
>
> Testing
> -------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error
due to storm-1.1.0-SNAPSHOT
Posted by Masahiro Tanaka <ta...@oss.nttdata.com>.
> On 4\u6708 29, 2017, 3:35 a.m., Aravindan Vijayan wrote:
> > Ship It!
Thank you! Could you commit it?
- Masahiro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
-----------------------------------------------------------
On 4\u6708 20, 2017, 11:59 p.m., Masahiro Tanaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> -----------------------------------------------------------
>
> (Updated 4\u6708 20, 2017, 11:59 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63
>
>
> Diff: https://reviews.apache.org/r/58575/diff/1/
>
>
> Testing
> -------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error
due to storm-1.1.0-SNAPSHOT
Posted by Aravindan Vijayan <av...@hortonworks.com>.
> On April 28, 2017, 6:35 p.m., Aravindan Vijayan wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you! Could you commit it?
Done. Please close the review and the jira.
- Aravindan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
-----------------------------------------------------------
On April 20, 2017, 2:59 p.m., Masahiro Tanaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 2:59 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63
>
>
> Diff: https://reviews.apache.org/r/58575/diff/1/
>
>
> Testing
> -------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error
due to storm-1.1.0-SNAPSHOT
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On April 20, 2017, 2:59 p.m., Masahiro Tanaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 2:59 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63
>
>
> Diff: https://reviews.apache.org/r/58575/diff/1/
>
>
> Testing
> -------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error
due to storm-1.1.0-SNAPSHOT
Posted by Masahiro Tanaka <ta...@oss.nttdata.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173189
-----------------------------------------------------------
Could anyone review this?
- Masahiro Tanaka
On April 20, 2017, 11:59 p.m., Masahiro Tanaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 11:59 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63
>
>
> Diff: https://reviews.apache.org/r/58575/diff/1/
>
>
> Testing
> -------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>