You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/22 08:15:45 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #66: [Feature Request] Introduce the unique trace id to debug easily
zuston opened a new issue, #66:
URL: https://github.com/apache/incubator-uniffle/issues/66
### Motivation
It's hard to analyze which process cost the most time of one remote request in current codebase, due to lacking corresponding trace id in client and server client.
### Plan
Maybe we could introduce the unique trace id which is generated on time/client-machine-id in one remote request, and then record it in client's log. And when requesting remote server, we should populate this to server and make it recorded in server's log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #66: [Feature Request] Introduce the unique trace id to debug easily
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #66:
URL: https://github.com/apache/incubator-uniffle/issues/66#issuecomment-1194117898
Maybe it will. But we could introduce new config to enable debug, default is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #66: [Feature Request] Introduce the unique trace id to debug easily
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #66:
URL: https://github.com/apache/incubator-uniffle/issues/66#issuecomment-1194244432
Got your point. Metric system is better for performance observation.
And i think i can invest this topic by submitting some PRs later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #66: [Feature Request] Introduce the unique trace id to debug easily
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #66:
URL: https://github.com/apache/incubator-uniffle/issues/66#issuecomment-1194187799
Do Flink have similar trace system? Flink don't have similar trace system. We ever implement this feature, but we don't choose to merge it. We just use that feature to get some information, the complexity which the feature brings is bigger than goodness. For offline system, metrics system may be better choice than trace system. Because although one time rpc is slow, but the average may be fast. I understand that we should add more Spark Metrics to show the rss's performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #66: [Feature Request] Introduce the unique trace id to debug easily
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #66:
URL: https://github.com/apache/incubator-uniffle/issues/66#issuecomment-1193991061
Will the feature influence the performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org