[GitHub] [inlong] aloyszhang commented on a diff in pull request #7253: [INLONG-7249][Sort] JDBC accurate dirty data archive and metric calculation

["aloyszhang (via GitHub)" <gi...@apache.org>]

aloyszhang commented on code in PR #7253:
URL: https://github.com/apache/inlong/pull/7253#discussion_r1098259077


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/dirty/DirtySinkHelper.java:
##########
@@ -95,6 +95,9 @@ public void invoke(T dirtyData, DirtyType dirtyType, Throwable e) {
                         .setLogTag(dirtyOptions.getLogTag())
                         .setDirtyMessage(e.getMessage())
                         .setIdentifier(dirtyOptions.getIdentifier());
+                LOGGER.info("dirty sink build debug: {}, {}, {}, {}, {}, {}",

Review Comment:
   We can't get the exact meaning of each element printed. 
   Suggestion :
   LOGGER.info("dirty sink build  data: {}, type: {}, lables: {}, tag: {}, Identifier: {}, errorMsg: {}", dirtyData, dirtyType, dirtyOptions.getLabels(), dirtyOptions.getLogTag(), dirtyOptions.getIdentifier(), e.getMessage());



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org