[jira] [Commented] (OFBIZ-10904) Creating custom Time Period does not show in party time period

["Pawan Verma (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098312#comment-17098312 ] 

Pawan Verma commented on OFBIZ-10904:
-------------------------------------

Sorry [~jleroux] for the very late reply :)

 I've review both the screen and there is on the main difference which I've found is:
1. Under Organization GL Settings we have organizationPartyId is a hidden field as a user can add/edit setting for current organization.
2. Under Global GL Settings, Users can enter the time period for any organization he/she provides.

I think that's why we have two separate screens for adding a new time period.

IMO provided patch is the simplest way to fix this problem. We can improve it in the future. WDYT?

> Creating custom Time Period does not show in party time period
> --------------------------------------------------------------
>
>                 Key: OFBIZ-10904
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10904
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 13.07, Release Branch 14.12, Release Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 17.12, Trunk
>            Reporter: Pierre Smits
>            Assignee: Pawan Verma
>            Priority: Major
>         Attachments: Image 006.png, Image 007.png, OFBIZ-10904.patch
>
>
> When a new time period is added in screen [1] the result does not show up in [2].
> [1] [https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod]
> [2] [https://demo-stable.ofbiz.apache.org/accounting/control/TimePeriods?organizationPartyId=Company]
> This is due to the fact that the field 'isClosed' is not set. Appropriate values are: Y or N.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)