You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/04/18 20:50:58 UTC
Review Request: FLUME-1128: Conf poller should use schedule with fixed delay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4791/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
As of now, this does not cause any issues. But if we were to increase the number of threads for some reason(say we add a 2nd configuration file), then it is possible for a 2nd conf poller to start up before the first one is done. So making this code clearer, by making it single threaded executor and also calling fixed delay rather than fixed rate.
This addresses bug FLUME-1128.
https://issues.apache.org/jira/browse/FLUME-1128
Diffs
-----
flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 64f4e35
Diff: https://reviews.apache.org/r/4791/diff
Testing
-------
All tests pass. Functional testing done.
Thanks,
Hari
Re: Review Request: FLUME-1128: Conf poller should use schedule with fixed
delay
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4791/#review7472
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-04-18 18:50:58, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4791/
> -----------------------------------------------------------
>
> (Updated 2012-04-18 18:50:58)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> As of now, this does not cause any issues. But if we were to increase the number of threads for some reason(say we add a 2nd configuration file), then it is possible for a 2nd conf poller to start up before the first one is done. So making this code clearer, by making it single threaded executor and also calling fixed delay rather than fixed rate.
>
>
> This addresses bug FLUME-1128.
> https://issues.apache.org/jira/browse/FLUME-1128
>
>
> Diffs
> -----
>
> flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 64f4e35
>
> Diff: https://reviews.apache.org/r/4791/diff
>
>
> Testing
> -------
>
> All tests pass. Functional testing done.
>
>
> Thanks,
>
> Hari
>
>