You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "joerghoh (via GitHub)" <gi...@apache.org> on 2026/09/22 11:39:06 UTC

[PR] SLING-13360 all log directives should handle CR/LF escaping [sling-org-apache-sling-engine]

joerghoh opened a new pull request, #91:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/91

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13360 all log directives should handle CR/LF escaping [sling-org-apache-sling-engine]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #91:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/91#issuecomment-5775828496

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=91) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [75.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=91&metric=new_coverage&view=list) (required ≥ 80%)  
     
   <!-- sqra:qg_revision=f1cbdcccae26a46e751c0505d168cdc050b560f4979bbc1a32e130f4419f1e68 -->
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=91)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13360 all log directives should handle CR/LF escaping [sling-org-apache-sling-engine]

Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on code in PR #91:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/91#discussion_r4072375247


##########
src/main/java/org/apache/sling/engine/impl/log/CustomLogFormat.java:
##########
@@ -547,7 +547,7 @@ public ThreadParameter(String parParam) {
         }
 
         protected String getValue(RequestLoggerRequest request) {
-            return Thread.currentThread().getName();
+            return escape(Thread.currentThread().getName());

Review Comment:
   Could we add a regression test for the `%P`/`ThreadParameter` case as well? This is one of the four directives explicitly covered by SLING-13360, but the current tests exercise only request parameters, content paths, and remote hosts.
   
   The missing case also leaves SonarQube at 75% coverage on new code, below the 80% quality gate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13360 all log directives should handle CR/LF escaping [sling-org-apache-sling-engine]

Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #91:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/91#discussion_r4085234046


##########
src/main/java/org/apache/sling/engine/impl/log/CustomLogFormat.java:
##########
@@ -547,7 +547,7 @@ public ThreadParameter(String parParam) {
         }
 
         protected String getValue(RequestLoggerRequest request) {
-            return Thread.currentThread().getName();
+            return escape(Thread.currentThread().getName());

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13360 all log directives should handle CR/LF escaping [sling-org-apache-sling-engine]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #91:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/91#issuecomment-5791836302

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=91) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=91&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=91&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=91&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=91&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=91&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=91)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13360 all log directives should handle CR/LF escaping [sling-org-apache-sling-engine]

Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh merged PR #91:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/91


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org