You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kevinyu98 <gi...@git.apache.org> on 2018/11/01 01:18:09 UTC
[GitHub] spark pull request #22918: [SPARK-25902][SQL]Change AttributeReference.withM...
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/22918
[SPARK-25902][SQL]Change AttributeReference.withMetadata's return type to AttributeReference
## What changes were proposed in this pull request?
Currently the `AttributeReference.withMetadata` method have return type `Attribute,` the rest of with methods in the `AttributeReference` return type are `AttributeReference`, as the [spark-25902](https://issues.apache.org/jira/browse/SPARK-25892?jql=project%20%3D%20SPARK%20AND%20component%20in%20(ML%2C%20PySpark%2C%20SQL)) mentioned.
## How was this patch tested?
Run all `sql/test,` `catalyst/test` and `org.apache.spark.sql.execution.streaming.*`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinyu98/spark spark-25892
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22918.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22918
----
commit 7aa2e9f9113ace0106ed1de31bad5997d600f03b
Author: Kevin Yu <qy...@...>
Date: 2018-10-31T22:40:04Z
return AttributeReference type for AttributeReference.withMetadata
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22918: [SPARK-25902][SQL]Change AttributeReference.withMetadata...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22918
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22918: [SPARK-25902][SQL]Change AttributeReference.withMetadata...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22918
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22918: [SPARK-25892][SQL]Change AttributeReference.withMetadata...
Posted by xuanyuanking <gi...@git.apache.org>.
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22918
The `as the spark-25902 mentioned.` in pr description maybe a typo? SPARK-25892?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22918: [SPARK-25892][SQL]Change AttributeReference.withMetadata...
Posted by kevinyu98 <gi...@git.apache.org>.
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/22918
@xuanyuanking thanks, I fixed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22918: [SPARK-25902][SQL]Change AttributeReference.withMetadata...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22918
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org