[GitHub] [maven-mvnd] gzm55 commented on a diff in pull request #721: Fixup #716 Calculate java home from java command

[GitBox <gi...@apache.org>]

gzm55 commented on code in PR #721:
URL: https://github.com/apache/maven-mvnd/pull/721#discussion_r998300127


##########
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##########
@@ -150,8 +150,11 @@ public Path javaHome() {
         }
     }
 
-    private String javaHomeFromPath() {
-        final String jHome = OsUtils.findJavaHomeFromPath();
+    private static String javaHomeFromPath() {
+        LOG.warn("Falling back to finding JAVA_HOME by running java executable available in PATH."

Review Comment:
   why warn here? the generic java version (mvnd.sh) will also search java from path without a warning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org